| Message ID | 1440570553-1600-2-git-send-email-g@maral.me |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
>>>>> "Guillermo" == Guillermo A Amaral <g@maral.me> writes:
Guillermo> The Crucial M500 is known to have issues with queued TRIM
Guillermo> commands, the factory recertified SSDs use a different model
Guillermo> number naming convention which causes them to get ignored by
Guillermo> the blacklist.
No particular objection to the patch. But I have asked Micron for
details since this may affect more of the blacklist entries.
On Tue, Aug 25, 2015 at 11:29:13PM -0700, Guillermo A. Amaral wrote: > The Crucial M500 is known to have issues with queued TRIM commands, the > factory recertified SSDs use a different model number naming convention > which causes them to get ignored by the blacklist. > > The new naming convention boils down to: s/Crucial_/FC/ > > Signed-off-by: Guillermo A. Amaral <g@maral.me> Applied to libata/for-4.2-fixes w/ stable cc'd. Thanks.
On Wed, Aug 26, 2015 at 8:24 AM, Martin K. Petersen <martin.petersen@oracle.com> wrote: >>>>>> "Guillermo" == Guillermo A Amaral <g@maral.me> writes: > > Guillermo> The Crucial M500 is known to have issues with queued TRIM > Guillermo> commands, the factory recertified SSDs use a different model > Guillermo> number naming convention which causes them to get ignored by > Guillermo> the blacklist. > > No particular objection to the patch. But I have asked Micron for > details since this may affect more of the blacklist entries. Good idea. I was waiting for a referb M550 that's in the mail to confirm if it also has a similar naming convention, but your approach seems much more direct. :)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 19bcb80..790e0de 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4230,6 +4230,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { ATA_HORKAGE_ZERO_AFTER_TRIM, }, { "Samsung SSD 8*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, }, + { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM, }, /* devices that don't properly handle TRIM commands */ { "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
The Crucial M500 is known to have issues with queued TRIM commands, the factory recertified SSDs use a different model number naming convention which causes them to get ignored by the blacklist. The new naming convention boils down to: s/Crucial_/FC/ Signed-off-by: Guillermo A. Amaral <g@maral.me> --- drivers/ata/libata-core.c | 2 ++ 1 file changed, 2 insertions(+)