diff mbox

[2/2] libata: force disable trim for SuperSSpeed S238

Message ID 1436873314-22563-3-git-send-email-arne_f@ipfire.org
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Arne Fitzenreiter July 14, 2015, 11:28 a.m. UTC 
this disc lose blocks if trim is used. most time the partition
area.
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tejun Heo July 14, 2015, 6:54 p.m. UTC | #1 
On Tue, Jul 14, 2015 at 01:28:34PM +0200, Arne Fitzenreiter wrote:
> this disc lose blocks if trim is used. most time the partition
> area.

This device loses blocks, often the partition table area, on trim.
Disable TRIM.

Signed-off-by:...
Cc: stable@vger.kernel.org  (the previous patch too)

Also, how did you learn that the device loses data on trim?  Is there
a report?  If this is something you noticed yourself, can you please
detail what you observed and how reproducible the problem is?

Thanks.
diff mbox

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index e83fc3d..d2d3b21 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4238,6 +4238,9 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "Samsung SSD 8*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
 						ATA_HORKAGE_ZERO_AFTER_TRIM, },
 
+	/* devices that don't properly handle TRIM commands */
+	{ "SuperSSpeed S238*",		NULL,	ATA_HORKAGE_NOTRIM, },
+
 	/*
 	 * As defined, the DRAT (Deterministic Read After Trim) and RZAT
 	 * (Return Zero After Trim) flags in the ATA Command Set are