| Message ID | 1418397391-13668-1-git-send-email-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 12/12/2014 06:16 PM, Andy Shevchenko wrote: > The driver sata_dwc_460ex is using this symbol. To build it as a module we have > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/ata/libata-eh.c | 1 + > 1 file changed, 1 insertion(+) > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > index 3dbec89..74fef87 100644 > --- a/drivers/ata/libata-eh.c > +++ b/drivers/ata/libata-eh.c > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) > > return NULL; > } > +EXPORT_SYMBOL(ata_get_cmd_descript); Why not EXPORT_SYMBOL_GPL()? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote: > Hello. > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote: > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/ata/libata-eh.c | 1 + > > 1 file changed, 1 insertion(+) > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > > index 3dbec89..74fef87 100644 > > --- a/drivers/ata/libata-eh.c > > +++ b/drivers/ata/libata-eh.c > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) > > > > return NULL; > > } > > +EXPORT_SYMBOL(ata_get_cmd_descript); > > Why not EXPORT_SYMBOL_GPL()? Some of the symbols are exported in that way. I think better to wait the maintainer to tell which is preferred there. > > MBR, Sergei >
On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote: > On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote: > > > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have > > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > drivers/ata/libata-eh.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > > > index 3dbec89..74fef87 100644 > > > --- a/drivers/ata/libata-eh.c > > > +++ b/drivers/ata/libata-eh.c > > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) > > > > > > return NULL; > > > } > > > +EXPORT_SYMBOL(ata_get_cmd_descript); > > > > Why not EXPORT_SYMBOL_GPL()? > > Some of the symbols are exported in that way. I think better to wait the > maintainer to tell which is preferred there. I don't really care. As the sole user is an in-kernel module, I'm gonna append _GPL for now. Thanks.
On Mon, 2015-01-05 at 11:21 -0500, Tejun Heo wrote: > On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote: > > On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote: > > > > > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have > > > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > --- > > > > drivers/ata/libata-eh.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > > > > index 3dbec89..74fef87 100644 > > > > --- a/drivers/ata/libata-eh.c > > > > +++ b/drivers/ata/libata-eh.c > > > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) > > > > > > > > return NULL; > > > > } > > > > +EXPORT_SYMBOL(ata_get_cmd_descript); > > > > > > Why not EXPORT_SYMBOL_GPL()? > > > > Some of the symbols are exported in that way. I think better to wait the > > maintainer to tell which is preferred there. > > I don't really care. As the sole user is an in-kernel module, I'm > gonna append _GPL for now. > I'm okay with GPL. Thanks!
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 3dbec89..74fef87 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command) return NULL; } +EXPORT_SYMBOL(ata_get_cmd_descript); /** * ata_eh_link_report - report error handling to user
The driver sata_dwc_460ex is using this symbol. To build it as a module we have to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)