| Message ID | 1390420593-27697-1-git-send-email-andrew@lunn.ch |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote: > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY > cannot be modular. Fixes build error found by kbuild test robot. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Applied to libata/for-3.14-fixes. Thanks.
On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote: > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote: > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY > > cannot be modular. Fixes build error found by kbuild test robot. > > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > Applied to libata/for-3.14-fixes. Thanks. > Tejun, Jason: The lack of this patch in -rc3, just made my Armada XP GP board panic. The panic is the same as this one (reported on Kirkwood): http://www.spinics.net/lists/arm-kernel/msg308080.html Which is fixed in linux-next (and should be in -rc4, right?) by: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5 The SATA won't get probed unless this commit from linux-next is also applied: commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52 Author: Andrew Lunn <andrew@lunn.ch> Date: Wed Jan 22 20:56:33 2014 +0100 ATA: SATA_MV: Add missing Kconfig select statememnt I guess it felt through someone cracks...
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote: > On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote: > > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote: > > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY > > > cannot be modular. Fixes build error found by kbuild test robot. > > > > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > > > Applied to libata/for-3.14-fixes. Thanks. > > > > Tejun, Jason: > > The lack of this patch in -rc3, just made my Armada XP GP board panic. > > The panic is the same as this one (reported on Kirkwood): > http://www.spinics.net/lists/arm-kernel/msg308080.html > > Which is fixed in linux-next (and should be in -rc4, right?) by: > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8ad116e649b21a42e3cccfb3c1b8d5ea52ba19e5 > > The SATA won't get probed unless this commit from linux-next is also applied: > > commit 49c8f1ffe26ffddfb7244a24db21c0b4a79e1c52 > Author: Andrew Lunn <andrew@lunn.ch> > Date: Wed Jan 22 20:56:33 2014 +0100 > > ATA: SATA_MV: Add missing Kconfig select statememnt > > I guess it felt through someone cracks... Well, sort of. By the time I saw it, and realized it should be kept next to the phy series fixes, Tejun had already taken it. Looking back, I don't have the patch in my inbox... thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 17, 2014 at 12:13:16PM -0300, Ezequiel Garcia wrote: > On Wed, Jan 29, 2014 at 01:20:35PM -0500, Tejun Heo wrote: > > On Wed, Jan 22, 2014 at 08:56:33PM +0100, Andrew Lunn wrote: > > > SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY > > > cannot be modular. Fixes build error found by kbuild test robot. > > > > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > > > Applied to libata/for-3.14-fixes. Thanks. > > > > Tejun, Jason: > > The lack of this patch in -rc3, just made my Armada XP GP board panic. Will push out soon. Thanks.
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 4e737728aee2..868429a47be4 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -247,6 +247,7 @@ config SATA_HIGHBANK config SATA_MV tristate "Marvell SATA support" + select GENERIC_PHY help This option enables support for the Marvell Serial ATA family. Currently supports 88SX[56]0[48][01] PCI(-X) chips,
SATA_MV depends on GENERIC_PHY. So if SATA_MV is built in, GENERIC_PHY cannot be modular. Fixes build error found by kbuild test robot. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)