From patchwork Wed Nov 20 09:28:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yijing Wang X-Patchwork-Id: 292697 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 31F582C0097 for ; Wed, 20 Nov 2013 20:30:25 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647Ab3KTJaX (ORCPT ); Wed, 20 Nov 2013 04:30:23 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:8375 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124Ab3KTJaW (ORCPT ); Wed, 20 Nov 2013 04:30:22 -0500 Received: from 172.24.2.119 (EHLO szxeml205-edg.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BLS00969; Wed, 20 Nov 2013 17:29:48 +0800 (CST) Received: from SZXEML402-HUB.china.huawei.com (10.82.67.32) by szxeml205-edg.china.huawei.com (172.24.2.58) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 20 Nov 2013 17:29:04 +0800 Received: from localhost (10.135.76.69) by szxeml402-hub.china.huawei.com (10.82.67.32) with Microsoft SMTP Server id 14.3.158.1; Wed, 20 Nov 2013 17:28:59 +0800 From: Yijing Wang To: Bjorn Helgaas , "Rafael J. Wysocki" , Jean Delvare , Guenter Roeck CC: Yijing Wang , Hanjun Guo , Tejun Heo , Subject: [PATCH 3/4] ata: Fix acpi_bus_get_device() return value check Date: Wed, 20 Nov 2013 17:28:25 +0800 Message-ID: <1384939706-6292-4-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.11.msysgit.1 In-Reply-To: <1384939706-6292-1-git-send-email-wangyijing@huawei.com> References: <1384939706-6292-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.135.76.69] X-CFilter-Loop: Reflected Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Since acpi_bus_get_device() returns plain int and not acpi_status, ACPI_FAILURE() should not be used for checking its return value. Fix that. Signed-off-by: Yijing Wang Cc: Tejun Heo Cc: linux-ide@vger.kernel.org Acked-by: Aaron Lu --- drivers/ata/libata-zpodd.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-zpodd.c b/drivers/ata/libata-zpodd.c index 68f9e32..3d9f82d 100644 --- a/drivers/ata/libata-zpodd.c +++ b/drivers/ata/libata-zpodd.c @@ -95,8 +95,7 @@ static bool odd_can_poweroff(struct ata_device *ata_dev) if (!handle) return false; - status = acpi_bus_get_device(handle, &acpi_dev); - if (ACPI_FAILURE(status)) + if (acpi_bus_get_device(handle, &acpi_dev)) return false; return acpi_device_can_poweroff(acpi_dev);