From patchwork Fri Apr 12 06:51:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Silviu-Mihai Popescu X-Patchwork-Id: 235976 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 164012C00B8 for ; Fri, 12 Apr 2013 16:51:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155Ab3DLGvW (ORCPT ); Fri, 12 Apr 2013 02:51:22 -0400 Received: from mail-ea0-f171.google.com ([209.85.215.171]:49938 "EHLO mail-ea0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909Ab3DLGvW (ORCPT ); Fri, 12 Apr 2013 02:51:22 -0400 Received: by mail-ea0-f171.google.com with SMTP id b15so1100331eae.2 for ; Thu, 11 Apr 2013 23:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=Jb0PTWzreP9okQtCMmWnpw1AtrXutFb0iMKSDnzKVqY=; b=uIcfzMYDzHDWk6+vj5jz7G3aD5CTGycSYoT4MLO0CiWn04LbSUD3Ox+1wVKyKj0Rz5 yXoyzaqr0YmxIhwJX0Qq+ka1QUpU6ThkDX+6jxCa7YOJNBmGUrIVM9wMCTwOtZbL0nG3 j3/p/Wn0hieKviJ75dBxWSmTdpoYlsE6DiKHcisutUjjy6exE/5v7C7+xDZ7l2LaMZtv /FH8U5hZBpnSCCsA8Y3FaACrpoSXYZVviOD04m8z+mVOqQejDHfq4dJkL9EYGb+rD1bv e9C6lFRe/aKL2oIGv0M6kvgygGjcFMNptFf2itBQzwaBTChFgqgG9ZKLZ51lP/9q3MGf u1Ew== X-Received: by 10.14.218.66 with SMTP id j42mr24757451eep.46.1365749480692; Thu, 11 Apr 2013 23:51:20 -0700 (PDT) Received: from localhost.localdomain (p5.eregie.pub.ro. [141.85.0.105]) by mx.google.com with ESMTPS id cd3sm9487491eeb.6.2013.04.11.23.51.19 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 11 Apr 2013 23:51:19 -0700 (PDT) From: Silviu-Mihai Popescu To: linux-ide@vger.kernel.org Cc: Jeff Garzik , linux-kernel@vger.kernel.org, Silviu-Mihai Popescu Subject: [PATCH] drivers: ata: rcar: use devm_ioremap_resource() Date: Fri, 12 Apr 2013 09:51:17 +0300 Message-Id: <1365749477-22770-1-git-send-email-silviupopescu1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu --- drivers/ata/sata_rcar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index caf33f6..8c51a3a 100644 --- a/drivers/ata/sata_rcar.c +++ b/drivers/ata/sata_rcar.c @@ -799,9 +799,9 @@ static int sata_rcar_probe(struct platform_device *pdev) host->private_data = priv; - priv->base = devm_request_and_ioremap(&pdev->dev, mem); - if (!priv->base) { - ret = -EADDRNOTAVAIL; + priv->base = devm_ioremap_resource(&pdev->dev, mem); + if (IS_ERR(priv->base)) { + ret = PTR_ERR(priv->base); goto cleanup; }