From patchwork Mon Mar 28 12:56:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Plyatov X-Patchwork-Id: 88598 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 84741B6FB8 for ; Mon, 28 Mar 2011 23:56:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680Ab1C1M40 (ORCPT ); Mon, 28 Mar 2011 08:56:26 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:34356 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224Ab1C1M4Z (ORCPT ); Mon, 28 Mar 2011 08:56:25 -0400 Received: by fxm17 with SMTP id 17so2610219fxm.19 for ; Mon, 28 Mar 2011 05:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=1AOxtUXgxOZ9p1kUBmlWVT9wKBrgaXrOgq08vb1wfp0=; b=Ws2qVLvxhRHeIwWXV/0TUxRujDm4of79PtUjKlFNlDxSTLyME+LplSgWtStSgkRxGR OebWL5e99OGaUsYlnevoDIo7S60F+vKDTHhFFuPLJTdO4L0ETEoHxJED2IQteHhmAC5c IpIaH1zZoeiXRDM4jz08uLIis/dAeEHurIVZI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=AgxM7ffJG547d5krMm5d4gW3xxcoZ7SJl4pcsdNnwL7iztUsmpOQBS3zQWVXTqrPiU uN9pEqOyJF7LWzKi6HpHUEP5UZU0+jb/dszhGNlhFcq+nFNtribBEWfgn2NiiUKfubK2 5iIEmPyjnYR7SLRt8iL3HMvgCiTKHQfxtDyXs= Received: by 10.223.160.5 with SMTP id l5mr2375067fax.85.1301316984365; Mon, 28 Mar 2011 05:56:24 -0700 (PDT) Received: from localhost.localdomain ([109.165.12.222]) by mx.google.com with ESMTPS id o12sm1473376fav.30.2011.03.28.05.56.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Mar 2011 05:56:23 -0700 (PDT) From: Igor Plyatov To: Jeff Garzik , linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Igor Plyatov Subject: [PATCH v4 1/2] ata: pata_at91.c bugfix for initial_timing initialisation Date: Mon, 28 Mar 2011 16:56:14 +0400 Message-Id: <1301316975-27761-1-git-send-email-plyatov@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was forgotten for "initial_timing" initialisation. This patch fixes such a problem. Signed-off-by: Igor Plyatov --- drivers/ata/pata_at91.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index 0da0dcc..0267d54 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -49,8 +49,18 @@ struct at91_ide_info { void __iomem *alt_addr; }; -static const struct ata_timing initial_timing = - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0}; +static const struct ata_timing initial_timing = { + .mode = XFER_PIO_0, + .setup = 70, + .act8b = 290, + .rec8b = 240, + .cyc8b = 600, + .active = 165, + .recover = 150, + .dmack_hold = 0, + .cycle = 600, + .udma = 0 +}; static unsigned long calc_mck_cycles(unsigned long ns, unsigned long mck_hz) {