| Message ID | 05b48a33-81ae-b1b1-428c-4a9a0c9a4fe8@users.sourceforge.net |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | PATA-Arasan CF: Adjustments for arasan_cf_probe() | expand |
On 16-02-18, 16:57, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 16 Feb 2018 16:01:12 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/ata/pata_arasan_cf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c > index b4d54771c9fe..be5fbcedecbf 100644 > --- a/drivers/ata/pata_arasan_cf.c > +++ b/drivers/ata/pata_arasan_cf.c > @@ -809,10 +809,8 @@ static int arasan_cf_probe(struct platform_device *pdev) > } > > acdev = devm_kzalloc(&pdev->dev, sizeof(*acdev), GFP_KERNEL); > - if (!acdev) { > - dev_warn(&pdev->dev, "kzalloc fail\n"); > + if (!acdev) > return -ENOMEM; > - } > > if (pdata) > quirk = pdata->quirk; Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index b4d54771c9fe..be5fbcedecbf 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -809,10 +809,8 @@ static int arasan_cf_probe(struct platform_device *pdev) } acdev = devm_kzalloc(&pdev->dev, sizeof(*acdev), GFP_KERNEL); - if (!acdev) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!acdev) return -ENOMEM; - } if (pdata) quirk = pdata->quirk;