mbox series

[v4,00/10] libata: remove references to 'old' error handler

Message ID 20230731143432.58886-1-nks@flawful.org
Headers show
Series libata: remove references to 'old' error handler | expand

Message

Niklas Cassel July 31, 2023, 2:34 p.m. UTC 
From: Niklas Cassel <niklas.cassel@wdc.com>

Hi all,

now that the ipr driver has been modified to not hook into libata
all drivers now use the 'new' error handler, so we can remove any
references to it. And do a general cleanup to remove callbacks
which are no longer needed.

Damien:
This patch series is based on v6.5-rc4, however it also applies to your
libata/for-next branch, if you cherry-pick commit 3ac873c76d79 ("ata:
libata-core: fix when to fetch sense data for successful commands"),
before applying the series (this patch is already in Torvald's tree).



Changes since v3:
-Rebased patch series so that it applies without conflicts.
-Picked up tags (John, Jason, Sergey, thank you!).
-Updated comment referring to a renamed function in hisi_sas_main.c.
-Added new patch 7/10 which removes ata_sas_port_init() (thanks John!).


Hannes Reinecke (6):
  ata: remove reference to non-existing error_handler()
  ata,scsi: remove ata_sas_port_{start,stop} callbacks
  ata,scsi: remove ata_sas_port_destroy()
  ata: remove ata_sas_sync_probe()
  ata: inline ata_port_probe()
  ata,scsi: cleanup __ata_port_probe()

Niklas Cassel (4):
  ata,scsi: remove ata_sas_port_init()
  ata: sata_sx4: drop already completed TODO
  ata: remove ata_bus_probe()
  ata: remove deprecated EH callbacks

 Documentation/driver-api/libata.rst   |  38 +--
 drivers/ata/libata-core.c             | 355 ++++++--------------------
 drivers/ata/libata-eh.c               | 152 +++++------
 drivers/ata/libata-sata.c             |  96 +------
 drivers/ata/libata-scsi.c             | 161 +-----------
 drivers/ata/libata-sff.c              |  30 +--
 drivers/ata/libata.h                  |   3 -
 drivers/ata/pata_sl82c105.c           |   3 +-
 drivers/ata/sata_sx4.c                |   1 -
 drivers/scsi/hisi_sas/hisi_sas_main.c |   2 +-
 drivers/scsi/libsas/sas_ata.c         |   9 +-
 drivers/scsi/libsas/sas_discover.c    |   2 +-
 include/linux/libata.h                |  16 +-
 13 files changed, 183 insertions(+), 685 deletions(-)

Comments

Martin K. Petersen July 31, 2023, 6:51 p.m. UTC | #1 
Niklas,

> now that the ipr driver has been modified to not hook into libata
> all drivers now use the 'new' error handler, so we can remove any
> references to it. And do a general cleanup to remove callbacks
> which are no longer needed.

LGTM.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Damien Le Moal Aug. 2, 2023, 8:48 a.m. UTC | #2 
On 7/31/23 23:34, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> Hi all,
> 
> now that the ipr driver has been modified to not hook into libata
> all drivers now use the 'new' error handler, so we can remove any
> references to it. And do a general cleanup to remove callbacks
> which are no longer needed.
> 
> Damien:
> This patch series is based on v6.5-rc4, however it also applies to your
> libata/for-next branch, if you cherry-pick commit 3ac873c76d79 ("ata:
> libata-core: fix when to fetch sense data for successful commands"),
> before applying the series (this patch is already in Torvald's tree).

Applied to for-6.6 with some tweaks to the commit titles.
Thanks !