From patchwork Mon Sep 30 09:08:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 278971 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 365382C009F for ; Mon, 30 Sep 2013 19:09:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176Ab3I3JJH (ORCPT ); Mon, 30 Sep 2013 05:09:07 -0400 Received: from mail-ea0-f171.google.com ([209.85.215.171]:51765 "EHLO mail-ea0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369Ab3I3JJG (ORCPT ); Mon, 30 Sep 2013 05:09:06 -0400 Received: by mail-ea0-f171.google.com with SMTP id n15so2542620ead.30 for ; Mon, 30 Sep 2013 02:09:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :content-type; bh=z5a79CBEP09EDJTrtpvwuyXE0WrBUvZSMvHEWO3ZJLg=; b=PT/sFHo+kRt0yfHOBtqqn/5dJpoL1XjXfOOFGsqYAXSHBqJT6Ri/QvY24CLFbiZ5ni FMmMnPMYxug5rHAJJzfevfnjAtEJO3b30FAg369P77fR6P4x6/jXJmreXuwc21zQMnjK lYNDlBlziFifPPZc445FMnsKr1svbdAfNmClJVJQtdVyINSmn1UVfKU5IAuY+GgY3Dnl SRy+rIgBqMguCaDR2GOy8cw8WK/pHhZT2PW1WxpfOFiI0tCVt743rXGWLCV6SWqaxDxX +qUZ76fWW5V4KH3mYhZYCZvhwRFlDVOShmr1PFocW/p/58O9q8ZzgPrtEWkL0aQjKWFE e7LQ== X-Gm-Message-State: ALoCoQlOa0YDjh2jY9E8Upp/LMscWTswW+E45d/t5HZX+Y7vcqjkN7GWTYWAOq1Ro1EKQWyS5pnv X-Received: by 10.14.183.2 with SMTP id p2mr35955501eem.44.1380532145253; Mon, 30 Sep 2013 02:09:05 -0700 (PDT) Received: from localhost (nat-63.starnet.cz. [178.255.168.63]) by mx.google.com with ESMTPSA id z12sm48815639eev.6.1969.12.31.16.00.00 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 30 Sep 2013 02:09:04 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: Kedareswara rao Appana , Wolfram Sang , Kedareswara rao Appana , Jean Delvare , Peter Korsgaard , linux-i2c@vger.kernel.org Subject: [PATCH 1/3] i2c: xilinx: Fix i2c sparse warnings Date: Mon, 30 Sep 2013 11:08:50 +0200 Message-Id: X-Mailer: git-send-email 1.8.2.3 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Kedareswara rao Appana code changes to fix sparse warnings Signed-off-by: Kedareswara rao Appana Signed-off-by: Michal Simek --- drivers/i2c/busses/i2c-xiic.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) -- 1.8.2.3 diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4c8b368..5eb0a8b 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -68,7 +68,7 @@ struct xiic_i2c { struct i2c_adapter adap; struct i2c_msg *tx_msg; spinlock_t lock; - unsigned int tx_pos; + unsigned int tx_pos; unsigned int nmsgs; enum xilinx_i2c_state state; struct i2c_msg *rx_msg; @@ -271,11 +271,8 @@ static void xiic_read_rx(struct xiic_i2c *i2c) bytes_in_fifo = xiic_getreg8(i2c, XIIC_RFO_REG_OFFSET) + 1; - dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d" - ", SR: 0x%x, CR: 0x%x\n", - __func__, bytes_in_fifo, xiic_rx_space(i2c), - xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), - xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); + dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d", + __func__, bytes_in_fifo, xiic_rx_space(i2c)); if (bytes_in_fifo > xiic_rx_space(i2c)) bytes_in_fifo = xiic_rx_space(i2c); @@ -339,9 +336,10 @@ static void xiic_process(struct xiic_i2c *i2c) ier = xiic_getreg32(i2c, XIIC_IIER_OFFSET); pend = isr & ier; - dev_dbg(i2c->adap.dev.parent, "%s entry, IER: 0x%x, ISR: 0x%x, " - "pend: 0x%x, SR: 0x%x, msg: %p, nmsgs: %d\n", - __func__, ier, isr, pend, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s: IER: 0x%x, ISR: 0x%x, pend: 0x%x\n", + __func__, ier, isr, pend); + dev_dbg(i2c->adap.dev.parent, "%s: SR: 0x%x, msg: %p, nmsgs: %d\n", + __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), i2c->tx_msg, i2c->nmsgs); /* Do not processes a devices interrupts if the device has no @@ -541,9 +539,10 @@ static void xiic_start_send(struct xiic_i2c *i2c) xiic_irq_clr(i2c, XIIC_INTR_TX_ERROR_MASK); - dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d, " - "ISR: 0x%x, CR: 0x%x\n", - __func__, msg, msg->len, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d", + __func__, msg, msg->len); + dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); if (!(msg->flags & I2C_M_NOSTART)) {