From patchwork Wed Jul 17 20:27:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Lutomirski X-Patchwork-Id: 259756 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A65292C0084 for ; Thu, 18 Jul 2013 06:28:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755915Ab3GQU2F (ORCPT ); Wed, 17 Jul 2013 16:28:05 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:59530 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755667Ab3GQU2E (ORCPT ); Wed, 17 Jul 2013 16:28:04 -0400 Received: by mail-pd0-f182.google.com with SMTP id r10so2229055pdi.13 for ; Wed, 17 Jul 2013 13:28:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=62wHiFhijcFOscsmBbKW/0IhKd6CcEvfU/nKT2HXIog=; b=el14XA09BZOnbBSqcG1vvPjO0Gxi/AZgZPbbQuY7xjTlCZz8F5LvwrQI8I5KVdWALz qBJf+XHwaUtQ2sl3FjwU40VYBjYRi0SVn9ZZW5zuL/z5j2599Zh59MQUE3J36/rRPkPd FtU1W0xHFBxyI/GH82WYVk3HGwW5oWW7AUaKHYt7VLkeI9BcoOv4DCTmfD0MkqLvxD8Z Crru6aZ9uT89Glf8IuHt1EOKeBQnoMOE2CYXTPtaSG14aRmZ/pdGb4KpmHLVFMA9jziI 8llWBFjYfK1+tUrYsyinPoZFHM140FydOTofUGnLBpSc7J/ZxX4u7tDkyDViLHzvhva9 outQ== X-Received: by 10.66.193.228 with SMTP id hr4mr7823372pac.163.1374092883708; Wed, 17 Jul 2013 13:28:03 -0700 (PDT) Received: from localhost (50-76-60-73-ip-static.hfc.comcastbusiness.net. [50.76.60.73]) by mx.google.com with ESMTPSA id ie3sm9571980pbc.13.2013.07.17.13.28.01 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 17 Jul 2013 13:28:02 -0700 (PDT) From: Andy Lutomirski To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Andy Lutomirski Subject: [PATCH] i2c: Improve logging on failure to probe for ->class devices Date: Wed, 17 Jul 2013 13:27:59 -0700 Message-Id: <7416fe787fbbe867a2a980b3a2e2de6cec7bf5f6.1374092773.git.luto@amacapital.net> X-Mailer: git-send-email 1.8.1.4 X-Gm-Message-State: ALoCoQnbwNfyJzUR1/SDOyLJ/gWel+cuxJg23DtFxCHt7zJbX/kg9TyYGp2xM7CfTWQNj2Lj5Vfr Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org While writing the i2c-imc driver, I noticed that the warning message when the i2c core can't figure out how to probe is mostly useless. This trivial patch improves it. Signed-off-by: Andy Lutomirski --- drivers/i2c/i2c-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 991d38d..213df0a 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -1502,7 +1502,8 @@ static int i2c_default_probe(struct i2c_adapter *adap, unsigned short addr) err = i2c_smbus_xfer(adap, addr, 0, I2C_SMBUS_READ, 0, I2C_SMBUS_BYTE, &dummy); else { - dev_warn(&adap->dev, "No suitable probing method supported\n"); + dev_warn(&adap->dev, "No suitable probing method supported for address 0x%02X\n", + addr); err = -EOPNOTSUPP; }