diff mbox series

i2c: I2C_KEBA should depend on KEBA_CP500

Message ID 39a6ce50b152c8e435c78825ab56aa714b54fce8.1727170404.git.geert+renesas@glider.be
State Accepted
Delegated to: Andi Shyti
Headers show
Series i2c: I2C_KEBA should depend on KEBA_CP500 | expand

Commit Message

Geert Uytterhoeven Sept. 24, 2024, 9:34 a.m. UTC
The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
a dependency on KEBA_CP500, to prevent asking the user about this driver
when configuring a kernel without KEBA CP500 system FPGA support.

Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Gerhard Engleder Sept. 24, 2024, 6:32 p.m. UTC | #1
On 24.09.24 11:34, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0ea437c76167ad2d..229b8166ccc03803 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -782,6 +782,7 @@ config I2C_JZ4780
>   config I2C_KEBA
>          tristate "KEBA I2C controller support"
>          depends on HAS_IOMEM
> +       depends on KEBA_CP500 || COMPILE_TEST

Makes sense. I will add that dependency to the next similar drivers.

Thanks!

Reviewed-by: Gerhard Engleder <eg@keba.com>
Andi Shyti Sept. 25, 2024, 1:52 p.m. UTC | #2
Hi Geert,

On Tue, Sep 24, 2024 at 11:34:18AM GMT, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for your fix, merged to i2c/i2c-host-fixes.

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 0ea437c76167ad2d..229b8166ccc03803 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -782,6 +782,7 @@  config I2C_JZ4780
 config I2C_KEBA
 	tristate "KEBA I2C controller support"
 	depends on HAS_IOMEM
+	depends on KEBA_CP500 || COMPILE_TEST
 	select AUXILIARY_BUS
 	help
 	  This driver supports the I2C controller found in KEBA system FPGA