diff mbox series

[1/2] dt-bindings: i2c: mux: i2c-demux-pinctrl: Drop i2c-mux.yaml reference

Message ID 20240124190552.1551929-1-robh@kernel.org
State Accepted
Delegated to: Andi Shyti
Headers show
Series [1/2] dt-bindings: i2c: mux: i2c-demux-pinctrl: Drop i2c-mux.yaml reference | expand

Commit Message

Rob Herring (Arm) Jan. 24, 2024, 7:05 p.m. UTC
The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
relevant and shouldn't be referenced.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml | 1 -
 1 file changed, 1 deletion(-)

Comments

Wolfram Sang Feb. 3, 2024, 8:50 p.m. UTC | #1
On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> relevant and shouldn't be referenced.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Wolfram Sang Feb. 26, 2024, 10:41 a.m. UTC | #2
On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > relevant and shouldn't be referenced.
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Andi, can you pick these up?

Or you negotiate with Rob how you want to handle I2C DT patches. I
agreed with him that I usually take them. Except for generic cleanups or
so.
Rob Herring (Arm) March 5, 2024, 6:06 p.m. UTC | #3
On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > relevant and shouldn't be referenced.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Andi, can you pick these up?

I already did since you gave your reviewed-by and they hadn't
otherwise been picked up.

> Or you negotiate with Rob how you want to handle I2C DT patches. I
> agreed with him that I usually take them. Except for generic cleanups or
> so.

Yes, that is my preference. And how most subsystems work for bindings.

Rob
Andi Shyti March 6, 2024, 7:20 a.m. UTC | #4
Hi Rob,

On Tue, Mar 05, 2024 at 12:06:05PM -0600, Rob Herring wrote:
> On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
> > On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > > relevant and shouldn't be referenced.
> > > >
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > >
> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > Andi, can you pick these up?
> 
> I already did since you gave your reviewed-by and they hadn't
> otherwise been picked up.

Oh... I had them in my test branch and was waiting for some more
tests before sending the notification.

Shall I remove them from my list?

Andi
Andi Shyti March 6, 2024, 11:51 a.m. UTC | #5
Hi Rob,

On Wed, Mar 06, 2024 at 08:20:27AM +0100, Andi Shyti wrote:
> On Tue, Mar 05, 2024 at 12:06:05PM -0600, Rob Herring wrote:
> > On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang
> > > On Sat, Feb 03, 2024 at 09:50:13PM +0100, Wolfram Sang wrote:
> > > > On Wed, Jan 24, 2024 at 01:05:50PM -0600, Rob Herring wrote:
> > > > > The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not
> > > > > relevant and shouldn't be referenced.
> > > > >
> > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > >
> > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > >
> > > Andi, can you pick these up?
> > 
> > I already did since you gave your reviewed-by and they hadn't
> > otherwise been picked up.
> 
> Oh... I had them in my test branch and was waiting for some more
> tests before sending the notification.
> 
> Shall I remove them from my list?

Because I need to update my branches, I am going to take these
two patches out. Please, let me know if you want me to take them
back in.

Thanks,
Andi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
index 2c08f2a7cf1e..dd3d24212551 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml
@@ -32,7 +32,6 @@  description: |
       +-------------------------------+
 
 allOf:
-  - $ref: i2c-mux.yaml
   - $ref: /schemas/i2c/i2c-controller.yaml#
 
 properties: