| Message ID | 20231119101445.4737-3-hkallweit1@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remove I2C_CLASS_DDC support | expand |
Am 19.11.23 um 11:14 schrieb Heiner Kallweit: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new code. So we can remove this class completely now. > > Preferably this series should be applied via the i2c tree. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > --- > drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c > index 0c48bdf3e..423eb302b 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c > +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c > @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) > i2c->data = BIT(info->i2c.data_bit); > i2c->clock = BIT(info->i2c.clock_bit); > i2c->adapter.owner = THIS_MODULE; > - i2c->adapter.class = I2C_CLASS_DDC; > i2c->adapter.dev.parent = dev->dev; > i2c->dev = dev; > i2c_set_adapdata(&i2c->adapter, i2c); >
diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c);
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-)