| Message ID | 20220127113303.3012207-2-bigeasy@linutronix.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Provide and use generic_handle_irq_safe() where appropriate. | expand |
Hi, On 1/27/22 12:32, Sebastian Andrzej Siewior wrote: > Provide generic_handle_irq_safe() which can be used can used from any > context. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > include/linux/irqdesc.h | 1 + > kernel/irq/irqdesc.c | 21 +++++++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h > index 93d270ca0c567..a77584593f7d1 100644 > --- a/include/linux/irqdesc.h > +++ b/include/linux/irqdesc.h > @@ -160,6 +160,7 @@ static inline void generic_handle_irq_desc(struct irq_desc *desc) > > int handle_irq_desc(struct irq_desc *desc); > int generic_handle_irq(unsigned int irq); > +int generic_handle_irq_safe(unsigned int irq); > > #ifdef CONFIG_IRQ_DOMAIN > /* > diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > index 2267e6527db3c..97223df2f460e 100644 > --- a/kernel/irq/irqdesc.c > +++ b/kernel/irq/irqdesc.c > @@ -662,6 +662,27 @@ int generic_handle_irq(unsigned int irq) > } > EXPORT_SYMBOL_GPL(generic_handle_irq); > > +/** > + * generic_handle_irq_safe - Invoke the handler for a particular irq > + * @irq: The irq number to handle > + * > + * Returns: 0 on success, or -EINVAL if conversion has failed > + * > + * This function must be called either from an IRQ context with irq regs > + * initialized or with care from any context. > + */ > +int generic_handle_irq_safe(unsigned int irq) > +{ > + unsigned long flags; > + int ret; > + > + local_irq_save(flags); > + ret = handle_irq_desc(irq_to_desc(irq)); > + local_irq_restore(flags); > + return ret; > +} > +EXPORT_SYMBOL_GPL(generic_handle_irq_safe); > + > #ifdef CONFIG_IRQ_DOMAIN > /** > * generic_handle_domain_irq - Invoke the handler for a HW irq belonging >
Hello. On Ätvrtek 27. ledna 2022 12:32:57 CET Sebastian Andrzej Siewior wrote: > Provide generic_handle_irq_safe() which can be used can used from any > context. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > include/linux/irqdesc.h | 1 + > kernel/irq/irqdesc.c | 21 +++++++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h > index 93d270ca0c567..a77584593f7d1 100644 > --- a/include/linux/irqdesc.h > +++ b/include/linux/irqdesc.h > @@ -160,6 +160,7 @@ static inline void generic_handle_irq_desc(struct irq_desc *desc) > > int handle_irq_desc(struct irq_desc *desc); > int generic_handle_irq(unsigned int irq); > +int generic_handle_irq_safe(unsigned int irq); > > #ifdef CONFIG_IRQ_DOMAIN > /* > diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > index 2267e6527db3c..97223df2f460e 100644 > --- a/kernel/irq/irqdesc.c > +++ b/kernel/irq/irqdesc.c > @@ -662,6 +662,27 @@ int generic_handle_irq(unsigned int irq) > } > EXPORT_SYMBOL_GPL(generic_handle_irq); > > +/** > + * generic_handle_irq_safe - Invoke the handler for a particular irq > + * @irq: The irq number to handle > + * > + * Returns: 0 on success, or -EINVAL if conversion has failed > + * > + * This function must be called either from an IRQ context with irq regs > + * initialized or with care from any context. > + */ > +int generic_handle_irq_safe(unsigned int irq) > +{ > + unsigned long flags; > + int ret; > + > + local_irq_save(flags); > + ret = handle_irq_desc(irq_to_desc(irq)); > + local_irq_restore(flags); > + return ret; > +} > +EXPORT_SYMBOL_GPL(generic_handle_irq_safe); > + > #ifdef CONFIG_IRQ_DOMAIN > /** > * generic_handle_domain_irq - Invoke the handler for a HW irq belonging > Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name> Thank you.
Hi Sebastian, > +/** > + * generic_handle_irq_safe - Invoke the handler for a particular irq This is the same desc as for generic_handle_irq(). I suggest to add something like "from any context" to have some distinction. > + * This function must be called either from an IRQ context with irq regs > + * initialized or with care from any context. I think "with care" is not obvious enough. Can you describe it a little? Thanks for this work, Wolfram
On 1/27/22 2:32 PM, Sebastian Andrzej Siewior wrote: > Provide generic_handle_irq_safe() which can be used can used from any ^^^^^^^^^^^^^^^^^^^^ You're repeating yourself. :-) > context. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> [...] MBR, Sergey
On 2022-01-27 18:03:29 [+0100], Wolfram Sang wrote: > Hi Sebastian, Hi Wolfram, > > +/** > > + * generic_handle_irq_safe - Invoke the handler for a particular irq > > This is the same desc as for generic_handle_irq(). I suggest to add > something like "from any context" to have some distinction. There is something later but let me reword that. > > + * This function must be called either from an IRQ context with irq regs > > + * initialized or with care from any context. > > I think "with care" is not obvious enough. Can you describe it a little? Yeah, will do. > Thanks for this work, > > Wolfram Sebastian
On 2022-01-28 13:18:14 [+0300], Sergei Shtylyov wrote: > On 1/27/22 2:32 PM, Sebastian Andrzej Siewior wrote: > > > Provide generic_handle_irq_safe() which can be used can used from any > ^^^^^^^^^^^^^^^^^^^^ > You're repeating yourself. :-) corrected, thank you. Sebastian
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h index 93d270ca0c567..a77584593f7d1 100644 --- a/include/linux/irqdesc.h +++ b/include/linux/irqdesc.h @@ -160,6 +160,7 @@ static inline void generic_handle_irq_desc(struct irq_desc *desc) int handle_irq_desc(struct irq_desc *desc); int generic_handle_irq(unsigned int irq); +int generic_handle_irq_safe(unsigned int irq); #ifdef CONFIG_IRQ_DOMAIN /* diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 2267e6527db3c..97223df2f460e 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -662,6 +662,27 @@ int generic_handle_irq(unsigned int irq) } EXPORT_SYMBOL_GPL(generic_handle_irq); +/** + * generic_handle_irq_safe - Invoke the handler for a particular irq + * @irq: The irq number to handle + * + * Returns: 0 on success, or -EINVAL if conversion has failed + * + * This function must be called either from an IRQ context with irq regs + * initialized or with care from any context. + */ +int generic_handle_irq_safe(unsigned int irq) +{ + unsigned long flags; + int ret; + + local_irq_save(flags); + ret = handle_irq_desc(irq_to_desc(irq)); + local_irq_restore(flags); + return ret; +} +EXPORT_SYMBOL_GPL(generic_handle_irq_safe); + #ifdef CONFIG_IRQ_DOMAIN /** * generic_handle_domain_irq - Invoke the handler for a HW irq belonging
Provide generic_handle_irq_safe() which can be used can used from any context. Suggested-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- include/linux/irqdesc.h | 1 + kernel/irq/irqdesc.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+)