| Message ID | 20210329105047.51033-8-heikki.krogerus@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: Adding support for software nodes | expand |
Hi, On 3/29/21 12:50 PM, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Hans de Goede <hdegoede@redhat.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/i2c/busses/i2c-cht-wc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index f80d79e973cd2..08f491ea21ac9 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -280,6 +280,10 @@ static const struct property_entry bq24190_props[] = { > { } > }; > > +static const struct software_node bq24190_node = { > + .properties = bq24190_props, > +}; > + > static struct regulator_consumer_supply fusb302_consumer = { > .supply = "vbus", > /* Must match fusb302 dev_name in intel_cht_int33fe.c */ > @@ -308,7 +312,7 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev) > .type = "bq24190", > .addr = 0x6b, > .dev_name = "bq24190", > - .properties = bq24190_props, > + .swnode = &bq24190_node, > .platform_data = &bq24190_pdata, > }; > int ret, reg, irq; >
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c index f80d79e973cd2..08f491ea21ac9 100644 --- a/drivers/i2c/busses/i2c-cht-wc.c +++ b/drivers/i2c/busses/i2c-cht-wc.c @@ -280,6 +280,10 @@ static const struct property_entry bq24190_props[] = { { } }; +static const struct software_node bq24190_node = { + .properties = bq24190_props, +}; + static struct regulator_consumer_supply fusb302_consumer = { .supply = "vbus", /* Must match fusb302 dev_name in intel_cht_int33fe.c */ @@ -308,7 +312,7 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev) .type = "bq24190", .addr = 0x6b, .dev_name = "bq24190", - .properties = bq24190_props, + .swnode = &bq24190_node, .platform_data = &bq24190_pdata, }; int ret, reg, irq;
Additional device properties are always just a part of a software fwnode. If the device properties are constant, the software node can also be constant. Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Cc: Hans de Goede <hdegoede@redhat.com> --- drivers/i2c/busses/i2c-cht-wc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)