| Message ID | 20201203214703.18258-1-Diego.SantaCruz@spinetix.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | misc: eeprom: at24: fix NVMEM name with custom AT24 device name | expand |
On Thu, Dec 3, 2020 at 10:47 PM Diego Santa Cruz <Diego.SantaCruz@spinetix.com> wrote: > > When the "label" property is set on the AT24 EEPROM the NVMEM devid is > set to NVMEM_DEVID_NONE, but it is not effective since there is a > leftover line setting it back to NVMEM_DEVID_AUTO a few lines after. > > Fixes: 61f764c307f6 ("eeprom: at24: Support custom device names for AT24 EEPROMs") > Signed-off-by: Diego Santa Cruz <Diego.SantaCruz@spinetix.com> > --- > drivers/misc/eeprom/at24.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index 35fabaf539b7..fbf69148b5ad 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -704,7 +704,6 @@ static int at24_probe(struct i2c_client *client) > > nvmem_config.type = NVMEM_TYPE_EEPROM; > nvmem_config.dev = dev; > - nvmem_config.id = NVMEM_DEVID_AUTO; > nvmem_config.read_only = !writable; > nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO); > nvmem_config.owner = THIS_MODULE; > -- > 2.18.4 > Goog catch, thanks. Applied to fixes. Bartosz
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 35fabaf539b7..fbf69148b5ad 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -704,7 +704,6 @@ static int at24_probe(struct i2c_client *client) nvmem_config.type = NVMEM_TYPE_EEPROM; nvmem_config.dev = dev; - nvmem_config.id = NVMEM_DEVID_AUTO; nvmem_config.read_only = !writable; nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO); nvmem_config.owner = THIS_MODULE;
When the "label" property is set on the AT24 EEPROM the NVMEM devid is set to NVMEM_DEVID_NONE, but it is not effective since there is a leftover line setting it back to NVMEM_DEVID_AUTO a few lines after. Fixes: 61f764c307f6 ("eeprom: at24: Support custom device names for AT24 EEPROMs") Signed-off-by: Diego Santa Cruz <Diego.SantaCruz@spinetix.com> --- drivers/misc/eeprom/at24.c | 1 - 1 file changed, 1 deletion(-)