Message ID | 20200831202303.15391-5-digetx@gmail.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-i2c-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=NJqsCF5l; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgM9v0S1Zz9sTd for <incoming@patchwork.ozlabs.org>; Tue, 1 Sep 2020 06:24:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgHaUYR (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Mon, 31 Aug 2020 16:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729986AbgHaUXc (ORCPT <rfc822;linux-i2c@vger.kernel.org>); Mon, 31 Aug 2020 16:23:32 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24791C061236; Mon, 31 Aug 2020 13:23:31 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id q8so4250529lfb.6; Mon, 31 Aug 2020 13:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6gUfms9VwMfk9ITu4jVbZVgXv6mmTy3KlTEz8VOyz88=; b=NJqsCF5l9/SOErOgl5TDzh418jpBPZse0a1qkyeseil06MU8o3wdPcs1ua9ehJm1fn 4OpRrE8OVB8JXV+KGCLD5UkT38vFAWxrCA2JlyJPMsrickBQ446ZKf41Wm0dPMzuG8Qq JCeCVMT6KEhaWBLskzkldSCcjprRRDr/Vd8BrVfUlVcxIHfLb7V0NiZXtWt/SXInVSx0 UhUweIpjrZd8u/I970pi2P5Y90dhqjX3THwcvnekxH7Hb3c8Li62WB7Saf/V1pEyawRY x9wmt6/yIpSl1JXzHPpAxTYdn8MQWdOfYrA65MxcLZgN9aQ6e71Uq6jhZYsHVCEvdyT4 SBxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6gUfms9VwMfk9ITu4jVbZVgXv6mmTy3KlTEz8VOyz88=; b=QnUUqqVwrDDnB6zyZQPCLbYe8pDAvR0HVid8WpI+YCKVhHi3aMVD1f4mSy1avkxueO do7SmqbMw9LkJiz2aOdTAuCmcHR9VCAoPTSsl3qNxm+EGYjklWbc+BixNleHvgHVqnCs /uXV4wC0NSzdXv2WoKMklE77EEAQL8UjPCPLtfY4Ae3BKFV/5iGPHNyAoqwfRWmvCoQD V7xswEaDVjT/HhMqyEQz2KTz7i3OfrxwET2RLO4Xz27XAd9c0Zx49lxNkG2ARdwOGrLj /xIQ+pLsQ1UuyVlZIgwy6KxwOPB2fcSfWTS6Ep6ZADG1/foN1K8ymKcTMnKsdlCmNTfm 3lgg== X-Gm-Message-State: AOAM531buUTc9W57xJK4dYSVrFU++gJ0YeO0iYveTGdU+VdW23fYg+tE jKwhlBbQU+5l+Z1S8ccJfYkEC59ufVo= X-Google-Smtp-Source: ABdhPJzbaQQoKggsHAFVZ3HnVI/ftrhvE0c2GEgHx3HYi2Pdoj5e0a0UhKuZF9JBGW63VOKWsTJgyA== X-Received: by 2002:a05:6512:20c1:: with SMTP id u1mr1442285lfr.17.1598905409571; Mon, 31 Aug 2020 13:23:29 -0700 (PDT) Received: from localhost.localdomain (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.gmail.com with ESMTPSA id z20sm1769054ljk.97.2020.08.31.13.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 13:23:29 -0700 (PDT) From: Dmitry Osipenko <digetx@gmail.com> To: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Laxman Dewangan <ldewangan@nvidia.com>, Wolfram Sang <wsa@the-dreams.de> Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 04/12] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error Date: Mon, 31 Aug 2020 23:22:55 +0300 Message-Id: <20200831202303.15391-5-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200831202303.15391-1-digetx@gmail.com> References: <20200831202303.15391-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: <linux-i2c.vger.kernel.org> X-Mailing-List: linux-i2c@vger.kernel.org |
Series |
Improvements for Tegra I2C driver
|
expand
|
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index efbb20049cf8..a7ef3a93e1b5 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1181,7 +1181,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, bool dma; u16 xfer_time = 100; - tegra_i2c_flush_fifos(i2c_dev); + err = tegra_i2c_flush_fifos(i2c_dev); + if (err) + return err; i2c_dev->msg_buf = msg->buf; i2c_dev->msg_buf_remaining = msg->len;
The tegra_i2c_flush_fifos() may fail and transfer should be aborted in this case. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/i2c/busses/i2c-tegra.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)