| Message ID | 20200521070847.13957-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: stm32f7: Fix runtime PM imbalance in stm32f7_i2c_unreg_slave | expand |
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 330ffed011e0..6f5f0fa68385 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -1837,8 +1837,10 @@ static int stm32f7_i2c_unreg_slave(struct i2c_client *slave) WARN_ON(!i2c_dev->slave[id]); ret = pm_runtime_get_sync(i2c_dev->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_autosuspend(i2c_dev->dev); return ret; + } if (id == 0) { mask = STM32F7_I2C_OAR1_OA1EN;
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/i2c/busses/i2c-stm32f7.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)