From patchwork Wed Feb 26 10:39:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 1244911 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48SCDz6y7fz9sPR for ; Wed, 26 Feb 2020 21:47:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbgBZKrq (ORCPT ); Wed, 26 Feb 2020 05:47:46 -0500 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:6600 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgBZKrq (ORCPT ); Wed, 26 Feb 2020 05:47:46 -0500 X-Greylist: delayed 543 seconds by postgrey-1.27 at vger.kernel.org; Wed, 26 Feb 2020 05:47:44 EST Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee85e564a9b2e7-50c0b; Wed, 26 Feb 2020 18:38:20 +0800 (CST) X-RM-TRANSID: 2ee85e564a9b2e7-50c0b X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.3.208.163]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee75e564a99c06-d63c9; Wed, 26 Feb 2020 18:38:19 +0800 (CST) X-RM-TRANSID: 2ee75e564a99c06-d63c9 From: tangbin To: wsa@the-dreams.de Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, tangbin Subject: [PATCH] i2c:i2c-core-of:remove redundant dev_err message Date: Wed, 26 Feb 2020 18:39:01 +0800 Message-Id: <20200226103901.21520-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org of_i2c_register_device already contains error message, so remove the redundant dev_err message Signed-off-by: tangbin --- drivers/i2c/i2c-core-of.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c index 6787c1f71..7b0a786d3 100644 --- a/drivers/i2c/i2c-core-of.c +++ b/drivers/i2c/i2c-core-of.c @@ -103,9 +103,7 @@ void of_i2c_register_devices(struct i2c_adapter *adap) client = of_i2c_register_device(adap, node); if (IS_ERR(client)) { - dev_err(&adap->dev, - "Failed to create I2C device for %pOF\n", - node); + return PTR_ERR(client); of_node_clear_flag(node, OF_POPULATED); } } @@ -246,8 +244,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, client = of_i2c_register_device(adap, rd->dn); if (IS_ERR(client)) { - dev_err(&adap->dev, "failed to create client for '%pOF'\n", - rd->dn); put_device(&adap->dev); of_node_clear_flag(rd->dn, OF_POPULATED); return notifier_from_errno(PTR_ERR(client));