diff mbox series

i2c: sh_mobile: use new clock calculation formulas for Gen2

Message ID 20190205170046.5046-1-wsa+renesas@sang-engineering.com
State Accepted
Headers show
Series i2c: sh_mobile: use new clock calculation formulas for Gen2 | expand

Commit Message

Wolfram Sang Feb. 5, 2019, 5 p.m. UTC 
We measured the clock on a Lager and an Ebisu board. The new formula
gives better results for both. So after Gen3, switch to this formula for
all Gen2 SoCs.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-sh_mobile.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Geert Uytterhoeven Feb. 5, 2019, 7:45 p.m. UTC | #1 
Hi Wolfram,

On Tue, Feb 5, 2019 at 6:01 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We measured the clock on a Lager and an Ebisu board. The new formula
> gives better results for both. So after Gen3, switch to this formula for
> all Gen2 SoCs.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

BTW, according to the datasheet, R-Mobile APE6 uses the same formulas
as R-Car Gen2, but you'll be able to verify that soon ;-)

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Feb. 8, 2019, 9:30 p.m. UTC | #2 
On Tue, Feb 05, 2019 at 06:00:46PM +0100, Wolfram Sang wrote:
> We measured the clock on a Lager and an Ebisu board. The new formula
> gives better results for both. So after Gen3, switch to this formula for
> all Gen2 SoCs.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 3c1552f14bec..6dfe1b3e2a3b 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -802,14 +802,14 @@  static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
 	{ .compatible = "renesas,iic-r8a7740", .data = &r8a7740_dt_config },
 	{ .compatible = "renesas,iic-r8a774c0", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,iic-r8a7790", .data = &v2_freq_calc_dt_config },
-	{ .compatible = "renesas,iic-r8a7791", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7792", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7793", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7794", .data = &fast_clock_dt_config },
+	{ .compatible = "renesas,iic-r8a7791", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7792", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7793", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7794", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-r8a7795", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-r8a77990", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,rcar-gen2-iic", .data = &fast_clock_dt_config },
+	{ .compatible = "renesas,rcar-gen2-iic", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,rcar-gen3-iic", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,rmobile-iic", .data = &default_dt_config },
 	{},