| Message ID | 20150325174351.GB5209@ulegcpding.emea.nsn-net.net |
|---|---|
| State | Superseded |
| Headers | show |
>>>>> "IN" == Ioan Nicu <ioan.nicu.ext@nsn.com> writes: IN> Probe deferral is not an error case. It happens only when IN> the necessary dependencies are not there yet. IN> The driver core is already printing a message when a driver IN> requests probe deferral, so this can be traced in the logs IN> without these error prints. IN> This patch changes the error messages from these deferral cases IN> to debug messages. IN> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com> Acked-by: Peter Korsgaard <peter.korsgaard@barco.com> -- Sorry about disclaimer - It's out of my control. Bye, Peter Korsgaard This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25/03/15 18:43, Ioan Nicu wrote: > Probe deferral is not an error case. It happens only when > the necessary dependencies are not there yet. > > The driver core is already printing a message when a driver > requests probe deferral, so this can be traced in the logs > without these error prints. > > This patch changes the error messages from these deferral cases > to debug messages. > > Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com> Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c > index f5798eb..9f1cfca 100644 > --- a/drivers/i2c/muxes/i2c-mux-gpio.c > +++ b/drivers/i2c/muxes/i2c-mux-gpio.c > @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, > } > adapter = of_find_i2c_adapter_by_node(adapter_np); > if (!adapter) { > - dev_err(&pdev->dev, "Cannot find parent bus\n"); > + dev_dbg(&pdev->dev, "Cannot find parent bus\n"); > return -EPROBE_DEFER; > } > mux->data.parent = i2c_adapter_id(adapter); > @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) > > parent = i2c_get_adapter(mux->data.parent); > if (!parent) { > - dev_err(&pdev->dev, "Parent adapter (%d) not found\n", > + dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n", > mux->data.parent); > return -EPROBE_DEFER; > }
On Wed, Mar 25, 2015 at 06:43:51PM +0100, Ioan Nicu wrote: > Probe deferral is not an error case. It happens only when > the necessary dependencies are not there yet. > > The driver core is already printing a message when a driver > requests probe deferral, so this can be traced in the logs > without these error prints. > > This patch changes the error messages from these deferral cases > to debug messages. > > Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com> Why not simply removing it?
On Fri, Mar 27, 2015 at 04:29:33PM +0100, ext Wolfram Sang wrote: > On Wed, Mar 25, 2015 at 06:43:51PM +0100, Ioan Nicu wrote: > > Probe deferral is not an error case. It happens only when > > the necessary dependencies are not there yet. > > > > The driver core is already printing a message when a driver > > requests probe deferral, so this can be traced in the logs > > without these error prints. > > > > This patch changes the error messages from these deferral cases > > to debug messages. > > > > Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com> > > Why not simply removing it? > Right, those messages are not relevant anyway, so removing them is better. I'll send out an updated patch. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index f5798eb..9f1cfca 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, } adapter = of_find_i2c_adapter_by_node(adapter_np); if (!adapter) { - dev_err(&pdev->dev, "Cannot find parent bus\n"); + dev_dbg(&pdev->dev, "Cannot find parent bus\n"); return -EPROBE_DEFER; } mux->data.parent = i2c_adapter_id(adapter); @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) parent = i2c_get_adapter(mux->data.parent); if (!parent) { - dev_err(&pdev->dev, "Parent adapter (%d) not found\n", + dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n", mux->data.parent); return -EPROBE_DEFER; }
Probe deferral is not an error case. It happens only when the necessary dependencies are not there yet. The driver core is already printing a message when a driver requests probe deferral, so this can be traced in the logs without these error prints. This patch changes the error messages from these deferral cases to debug messages. Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com> --- drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)