| Message ID | 1639680494-23183-11-git-send-email-abel.vesa@nxp.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm64: dts: Add i.MX8DXL initial support | expand |
On Thu, Dec 16, 2021 at 08:48:14PM +0200, Abel Vesa wrote: > Add i.MX8DXL lpuart compatible to the bindings documentation. > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > --- > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > index fa23c60a01d0..ee37aa125c86 100644 > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > @@ -29,6 +29,10 @@ properties: > - items: > - const: fsl,imx8qm-lpuart > - const: fsl,imx8qxp-lpuart > + - items: > + - const: fsl,imx8dxl-lpuart > + - const: fsl,imx8qxp-lpuart > + - const: fsl,imx7ulp-lpuart Why is "- items:" listed twice here? thanks, greg k-h
On 21-12-17 17:59:26, Greg Kroah-Hartman wrote: > On Thu, Dec 16, 2021 at 08:48:14PM +0200, Abel Vesa wrote: > > Add i.MX8DXL lpuart compatible to the bindings documentation. > > > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > > --- > > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > index fa23c60a01d0..ee37aa125c86 100644 > > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > @@ -29,6 +29,10 @@ properties: > > - items: > > - const: fsl,imx8qm-lpuart > > - const: fsl,imx8qxp-lpuart > > + - items: > > + - const: fsl,imx8dxl-lpuart > > + - const: fsl,imx8qxp-lpuart > > + - const: fsl,imx7ulp-lpuart > > Why is "- items:" listed twice here? There are actually 3 "- items:" and there is a "oneOf:" that encloses all of these. Unfortunately, there are special cases within the driver that forces the devicetree nodes to have a different list of compatibles for almost each SoC. > > thanks, > > greg k-h
On Sat, Dec 18, 2021 at 11:58:46PM +0200, Abel Vesa wrote: > On 21-12-17 17:59:26, Greg Kroah-Hartman wrote: > > On Thu, Dec 16, 2021 at 08:48:14PM +0200, Abel Vesa wrote: > > > Add i.MX8DXL lpuart compatible to the bindings documentation. > > > > > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > > > --- > > > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > > index fa23c60a01d0..ee37aa125c86 100644 > > > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > > @@ -29,6 +29,10 @@ properties: > > > - items: > > > - const: fsl,imx8qm-lpuart > > > - const: fsl,imx8qxp-lpuart > > > + - items: > > > + - const: fsl,imx8dxl-lpuart > > > + - const: fsl,imx8qxp-lpuart > > > + - const: fsl,imx7ulp-lpuart > > > > Why is "- items:" listed twice here? > > There are actually 3 "- items:" and there is a "oneOf:" > that encloses all of these. > > Unfortunately, there are special cases within the driver > that forces the devicetree nodes to have a different list of > compatibles for almost each SoC. Ah. Can you resend it as it is long-gone from my queue now. thanks, greg k-h
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml index fa23c60a01d0..ee37aa125c86 100644 --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml @@ -29,6 +29,10 @@ properties: - items: - const: fsl,imx8qm-lpuart - const: fsl,imx8qxp-lpuart + - items: + - const: fsl,imx8dxl-lpuart + - const: fsl,imx8qxp-lpuart + - const: fsl,imx7ulp-lpuart reg: maxItems: 1
Add i.MX8DXL lpuart compatible to the bindings documentation. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ 1 file changed, 4 insertions(+)