diff mbox series

[v2,1/2] i2c: imx: Fix PM runtime inbalance in probe error path

Message ID 1592130544-19759-1-git-send-email-krzk@kernel.org
State Needs Review / ACK
Headers show
Series [v2,1/2] i2c: imx: Fix PM runtime inbalance in probe error path | expand

Commit Message

Krzysztof Kozlowski June 14, 2020, 10:29 a.m. UTC
When pm_runtime_get_sync() fails in probe(), the error path should not
call pm_runtime_put_noidle().  This would lead to inbalance in
usage_count.

Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. New patch
---
 drivers/i2c/busses/i2c-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski June 15, 2020, 6:50 a.m. UTC | #1
On Sun, Jun 14, 2020 at 12:29:03PM +0200, Krzysztof Kozlowski wrote:
> When pm_runtime_get_sync() fails in probe(), the error path should not
> call pm_runtime_put_noidle().  This would lead to inbalance in
> usage_count.
> 
> Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Changes since v1:
> 1. New patch

This patch is not correct because the runtime usage counter is increased
always, also on failures.

It can be dropped.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0ab5381aa012..6e45958565d1 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1239,8 +1239,8 @@  static int i2c_imx_probe(struct platform_device *pdev)
 
 clk_notifier_unregister:
 	clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb);
-rpm_disable:
 	pm_runtime_put_noidle(&pdev->dev);
+rpm_disable:
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
 	pm_runtime_dont_use_autosuspend(&pdev->dev);