diff mbox series

dt-bindings: i2c: sh_mobile: Add r8a774c0 support

Message ID 1544732352-6178-1-git-send-email-fabrizio.castro@bp.renesas.com
State Superseded
Headers show
Series dt-bindings: i2c: sh_mobile: Add r8a774c0 support | expand

Commit Message

Fabrizio Castro Dec. 13, 2018, 8:19 p.m. UTC
Document RZ/G2E (R8A774C0) SoC bindings.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Rosin Dec. 13, 2018, 9:57 p.m. UTC | #1
On 2018-12-13 21:19, Fabrizio Castro wrote:
> Document RZ/G2E (R8A774C0) SoC bindings.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> index bc876b7..3dff89f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> @@ -8,6 +8,7 @@ Required properties:
>  			- "renesas,iic-r8a7744" (RZ/G1N)
>  			- "renesas,iic-r8a7745" (RZ/G1E)
>  			- "renesas,iic-r8a774a1" (RZ/G2M)
> +			- "renesas,iic-r8a774c0" (RZ/G2E)
>  			- "renesas,iic-r8a7790" (R-Car H2)
>  			- "renesas,iic-r8a7791" (R-Car M2-W)
>  			- "renesas,iic-r8a7792" (R-Car V2H)
> @@ -32,7 +33,7 @@ Required properties:
>  			When compatible with "renesas,rmobile-iic" it should
>  			be the last compatibility string listed.
>  
> -			The r8a77990 (R-Car E3) controller is not
> +			The r8a77990 (R-Car E3) and RZ/G2E controllers are not

The references to these two controllers do not follow the same style.
I'd either delete r8a77990 and get "R-Car E3 and RZ/G2E" or add
r8a774c0 in front of RZ/G2E (bracketed), with a slight preference
for the latter.

Cheers,
Peter

>  			considered compatible with "renesas,rcar-gen3-iic"
>  			or "renesas,rmobile-iic" due to the absence of
>  			automatic transmission registers.
>
Fabrizio Castro Dec. 14, 2018, 8:13 a.m. UTC | #2
Hello Peter,

Thank you for your feedback!

> From: Peter Rosin <peda@axentia.se>
> Sent: 13 December 2018 21:58
> Subject: Re: [PATCH] dt-bindings: i2c: sh_mobile: Add r8a774c0 support
>
> On 2018-12-13 21:19, Fabrizio Castro wrote:
> > Document RZ/G2E (R8A774C0) SoC bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> > index bc876b7..3dff89f 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> > @@ -8,6 +8,7 @@ Required properties:
> >  - "renesas,iic-r8a7744" (RZ/G1N)
> >  - "renesas,iic-r8a7745" (RZ/G1E)
> >  - "renesas,iic-r8a774a1" (RZ/G2M)
> > +- "renesas,iic-r8a774c0" (RZ/G2E)
> >  - "renesas,iic-r8a7790" (R-Car H2)
> >  - "renesas,iic-r8a7791" (R-Car M2-W)
> >  - "renesas,iic-r8a7792" (R-Car V2H)
> > @@ -32,7 +33,7 @@ Required properties:
> >  When compatible with "renesas,rmobile-iic" it should
> >  be the last compatibility string listed.
> >
> > -The r8a77990 (R-Car E3) controller is not
> > +The r8a77990 (R-Car E3) and RZ/G2E controllers are not
>
> The references to these two controllers do not follow the same style.
> I'd either delete r8a77990 and get "R-Car E3 and RZ/G2E" or add
> r8a774c0 in front of RZ/G2E (bracketed), with a slight preference
> for the latter.

You are right, I'll send a v2 to address this.

Thanks,
Fab

>
> Cheers,
> Peter
>
> >  considered compatible with "renesas,rcar-gen3-iic"
> >  or "renesas,rmobile-iic" due to the absence of
> >  automatic transmission registers.
> >


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
index bc876b7..3dff89f 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
@@ -8,6 +8,7 @@  Required properties:
 			- "renesas,iic-r8a7744" (RZ/G1N)
 			- "renesas,iic-r8a7745" (RZ/G1E)
 			- "renesas,iic-r8a774a1" (RZ/G2M)
+			- "renesas,iic-r8a774c0" (RZ/G2E)
 			- "renesas,iic-r8a7790" (R-Car H2)
 			- "renesas,iic-r8a7791" (R-Car M2-W)
 			- "renesas,iic-r8a7792" (R-Car V2H)
@@ -32,7 +33,7 @@  Required properties:
 			When compatible with "renesas,rmobile-iic" it should
 			be the last compatibility string listed.
 
-			The r8a77990 (R-Car E3) controller is not
+			The r8a77990 (R-Car E3) and RZ/G2E controllers are not
 			considered compatible with "renesas,rcar-gen3-iic"
 			or "renesas,rmobile-iic" due to the absence of
 			automatic transmission registers.