diff mbox series

[v2,02/13] i2c: qup: fixed releasing dma without flush operation completion

Message ID 1520860502-14886-3-git-send-email-absahu@codeaurora.org
State Accepted
Headers show
Series Major code reorganization to make all i2c transfers working | expand

Commit Message

Abhishek Sahu March 12, 2018, 1:14 p.m. UTC
The QUP BSLP BAM generates the following error sometimes if the
current I2C DMA transfer fails and the flush operation has been

    “bam-dma-engine 7884000.dma: Cannot free busy channel”

If any I2C error comes during BAM DMA transfer, then the QUP I2C
interrupt will be generated and the flush operation will be
carried out to make I2C consume all scheduled DMA transfer.
Currently, the same completion structure is being used for BAM
transfer which has already completed without reinit. It will make
flush operation wait_for_completion_timeout completed immediately
and will proceed for freeing the DMA resources where the
descriptors are still in process.

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Acked-by: Sricharan R <sricharan@codeaurora.org>
Reviewed-by: Austin Christ <austinwc@codeaurora.org>
Reviewed-by: Andy Gross <andy.gross@linaro.org>

* Changes from v1:

1. Removed copyright and added in separate patch with SPDX license

 drivers/i2c/busses/i2c-qup.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index ac5edfa..75e9819 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -835,6 +835,8 @@  static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg,
 	if (ret || qup->bus_err || qup->qup_err) {
+		reinit_completion(&qup->xfer);
 		if (qup_i2c_change_state(qup, QUP_RUN_STATE)) {
 			dev_err(qup->dev, "change to run state timed out");
 			goto desc_err;