From patchwork Sat Feb 3 07:58:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 868866 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Cdu8AHqC"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Cdu8AHqC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zYRBn6qzzz9t3x for ; Sat, 3 Feb 2018 19:01:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbeBCH7Y (ORCPT ); Sat, 3 Feb 2018 02:59:24 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35634 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbeBCH6z (ORCPT ); Sat, 3 Feb 2018 02:58:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 43E01608BF; Sat, 3 Feb 2018 07:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517644731; bh=3bRtgW/1UGLSHkCpuK0MvWwju03sHmRucFoxDy+Zr7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cdu8AHqCIY7qQbWd2ZS4eB9E+po8NKJ+9IDMCDvVAs0IfkckPc59wlM/J/QtjEEFI d0tlzT3wWy9g3j73CU92Nq3CrsO32l1Q0dOZqMjrcdJB6qLcXaM1J24bDCpnbAslwY jt1i53F3cTiufw0NyMMO43NZT1iCax1lBzRl8zIw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 795246079C; Sat, 3 Feb 2018 07:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517644731; bh=3bRtgW/1UGLSHkCpuK0MvWwju03sHmRucFoxDy+Zr7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cdu8AHqCIY7qQbWd2ZS4eB9E+po8NKJ+9IDMCDvVAs0IfkckPc59wlM/J/QtjEEFI d0tlzT3wWy9g3j73CU92Nq3CrsO32l1Q0dOZqMjrcdJB6qLcXaM1J24bDCpnbAslwY jt1i53F3cTiufw0NyMMO43NZT1iCax1lBzRl8zIw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 795246079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: Andy Gross , Wolfram Sang Cc: David Brown , Sricharan R , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abhishek Sahu Subject: [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode Date: Sat, 3 Feb 2018 13:28:12 +0530 Message-Id: <1517644697-30806-8-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Currently each message length in complete transfer is being checked for determining DMA mode and if any of the message length is less than FIFO length then non DMA mode is being used which will increase overhead. DMA can be used for any length and it should be determined with complete transfer length. Now, this patch introduces DMA threshold length and the transfer will be done in DMA mode if the total length is greater than this threshold length. Signed-off-by: Abhishek Sahu Reviewed-by: Austin Christ Reviewed-by: Andy Gross --- drivers/i2c/busses/i2c-qup.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 6227a5c..a91fc70 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -192,6 +192,8 @@ struct qup_i2c_dev { bool is_dma; /* To check if the current transfer is using DMA */ bool use_dma; + /* The threshold length above which DMA will be used */ + unsigned int dma_threshold; struct dma_pool *dpool; struct qup_i2c_tag start_tag; struct qup_i2c_bam brx; @@ -1294,7 +1296,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, int num) { struct qup_i2c_dev *qup = i2c_get_adapdata(adap); - int ret, len, idx = 0; + int ret, idx = 0; + unsigned int total_len = 0; qup->bus_err = 0; qup->qup_err = 0; @@ -1320,14 +1323,13 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, goto out; } - len = (msgs[idx].len > qup->out_fifo_sz) || - (msgs[idx].len > qup->in_fifo_sz); - - if (is_vmalloc_addr(msgs[idx].buf) || !len) + if (is_vmalloc_addr(msgs[idx].buf)) break; + + total_len += msgs[idx].len; } - if (idx == num) + if (idx == num && total_len > qup->dma_threshold) qup->use_dma = true; } @@ -1587,6 +1589,7 @@ static int qup_i2c_probe(struct platform_device *pdev) size = QUP_INPUT_FIFO_SIZE(io_mode); qup->in_fifo_sz = qup->in_blk_sz * (2 << size); + qup->dma_threshold = min(qup->out_fifo_sz, qup->in_fifo_sz); fs_div = ((src_clk_freq / clk_freq) / 2) - 3; hs_div = 3;