diff mbox series

[v4,2/2] dt-bindings: add eeprom "at24,no-read-rollover" property

Message ID 1512487422-6284-3-git-send-email-svendev@arcx.com
State Superseded
Delegated to: Bartosz Golaszewski
Headers show
Series at24: support eeproms that do not auto-rollover reads. | expand

Commit Message

Sven Van Asbroeck Dec. 5, 2017, 3:23 p.m. UTC
Adds an optional property for at24 eeproms.
This parameterless property indicates that the multi-address eeprom
does not automatically roll over reads to the next slave address.

Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
---
 Documentation/devicetree/bindings/eeprom/eeprom.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring Dec. 6, 2017, 10:04 p.m. UTC | #1
On Tue, Dec 05, 2017 at 10:23:42AM -0500, Sven Van Asbroeck wrote:
> Adds an optional property for at24 eeproms.
> This parameterless property indicates that the multi-address eeprom
> does not automatically roll over reads to the next slave address.
> 
> Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 27f2bc1..5bfc0ac 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -38,6 +38,11 @@ Optional properties:
>  
>    - size: total eeprom size in bytes
>  
> +  - at24,no-read-rollover:

at24 is not a vendor prefix. Either this is atmel specific and you want 
atmel,no-read-rollover or it is for all vendors at24 compatible eeproms 
and you want at24-no-read-rollover. Or just drop the at24 if this 
binding is in fact for just at24 eeproms as none of the other properties 
has at24 in them.

> +			This parameterless property indicates that the multi-address
> +			eeprom does not automatically roll over reads to the next
> +			slave address. Please consult the manual of your device.
> +
>  Example:
>  
>  eeprom@52 {
> -- 
> 1.9.1
>
Sven Van Asbroeck Dec. 7, 2017, 2:06 p.m. UTC | #2
> at24 is not a vendor prefix. Either this is atmel specific and you want
> atmel,no-read-rollover or it is for all vendors at24 compatible eeproms
> and you want at24-no-read-rollover. Or just drop the at24 if this
> binding is in fact for just at24 eeproms as none of the other properties
> has at24 in them.

Bartosz, shall I rename
at24,no-read-rollover -> no-read-rollover ?
Bartosz Golaszewski Dec. 7, 2017, 2:21 p.m. UTC | #3
2017-12-07 15:06 GMT+01:00 Sven Van Asbroeck <thesven73@gmail.com>:
>> at24 is not a vendor prefix. Either this is atmel specific and you want
>> atmel,no-read-rollover or it is for all vendors at24 compatible eeproms
>> and you want at24-no-read-rollover. Or just drop the at24 if this
>> binding is in fact for just at24 eeproms as none of the other properties
>> has at24 in them.
>
> Bartosz, shall I rename
> at24,no-read-rollover -> no-read-rollover ?

Yes, please.

Thanks,
Bartosz
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
index 27f2bc1..5bfc0ac 100644
--- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
+++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
@@ -38,6 +38,11 @@  Optional properties:
 
   - size: total eeprom size in bytes
 
+  - at24,no-read-rollover:
+			This parameterless property indicates that the multi-address
+			eeprom does not automatically roll over reads to the next
+			slave address. Please consult the manual of your device.
+
 Example:
 
 eeprom@52 {