| Message ID | 1502332061-25085-2-git-send-email-jun.gao@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > From: Jun Gao <jun.gao@mediatek.com> > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > controller, MT7622 limits message numbers to 255, and does not > support 4GB DMA mode. > > Signed-off-by: Jun Gao <jun.gao@mediatek.com> > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > index bd5a7be..ff9ac61 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > + "mediatek,mt6577-i2c": for Mediatek MT6577 > + "mediatek,mt6589-i2c": for Mediatek MT6589 Better not change those and just add compatible strings for mt7622. > + "mediatek,mt7622-i2c": for Mediatek MT7622 > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > + "mediatek,mt8173-i2c": for Mediatek MT8173 > - reg: physical base address of the controller and dma base, length of memory > mapped region. > - interrupts: interrupt number to the cpu.
On Thu, 2017-08-10 at 16:19 +0800, Honghui Zhang wrote: > On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > > From: Jun Gao <jun.gao@mediatek.com> > > > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > > controller, MT7622 limits message numbers to 255, and does not > > support 4GB DMA mode. > > > > Signed-off-by: Jun Gao <jun.gao@mediatek.com> > > --- > > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > index bd5a7be..ff9ac61 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > > > Required properties: > > - compatible: value should be either of the following. > > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > + "mediatek,mt6577-i2c": for Mediatek MT6577 > > + "mediatek,mt6589-i2c": for Mediatek MT6589 > > Better not change those and just add compatible strings for mt7622. > It seems better to use the same format for all SoCs. Jun > > + "mediatek,mt7622-i2c": for Mediatek MT7622 > > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > + "mediatek,mt8173-i2c": for Mediatek MT8173 > > - reg: physical base address of the controller and dma base, length of memory > > mapped region. > > - interrupts: interrupt number to the cpu. > >
On Fri, 2017-08-11 at 09:37 +0800, Jun Gao wrote: > On Thu, 2017-08-10 at 16:19 +0800, Honghui Zhang wrote: > > On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > > > From: Jun Gao <jun.gao@mediatek.com> > > > > > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > > > controller, MT7622 limits message numbers to 255, and does not > > > support 4GB DMA mode. > > > > > > Signed-off-by: Jun Gao <jun.gao@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > index bd5a7be..ff9ac61 100644 > > > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > > > > > Required properties: > > > - compatible: value should be either of the following. > > > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > > > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > > > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > > > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > > > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > > + "mediatek,mt6577-i2c": for Mediatek MT6577 > > > + "mediatek,mt6589-i2c": for Mediatek MT6589 > > > > Better not change those and just add compatible strings for mt7622. > > > It seems better to use the same format for all SoCs. > Alright, do you need to put those changes in commit message? Thanks. > Jun > > > + "mediatek,mt7622-i2c": for Mediatek MT7622 > > > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > > + "mediatek,mt8173-i2c": for Mediatek MT8173 > > > - reg: physical base address of the controller and dma base, length of memory > > > mapped region. > > > - interrupts: interrupt number to the cpu. > > > > > >
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt index bd5a7be..ff9ac61 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. Required properties: - compatible: value should be either of the following. - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 - "mediatek,mt6577-i2c": for i2c compatible with mt6577. - "mediatek,mt6589-i2c": for i2c compatible with mt6589. - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. - "mediatek,mt8173-i2c": for i2c compatible with mt8173. + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 + "mediatek,mt6577-i2c": for Mediatek MT6577 + "mediatek,mt6589-i2c": for Mediatek MT6589 + "mediatek,mt7622-i2c": for Mediatek MT7622 + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 + "mediatek,mt8173-i2c": for Mediatek MT8173 - reg: physical base address of the controller and dma base, length of memory mapped region. - interrupts: interrupt number to the cpu.