diff mbox

i2c: zx2967: drop COMPILE_TEST dependency

Message ID 1498314326-16121-1-git-send-email-shawnguo@kernel.org
State Accepted
Headers show

Commit Message

Shawn Guo June 24, 2017, 2:25 p.m. UTC 
From: Shawn Guo <shawn.guo@linaro.org>

0-DAY kernel test reports the following build issue on IA64 architecture
with allmodconfig.

   drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_writesb':
>> drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' [-Werror=implicit-function-declaration]
     writesb(i2c->reg_base + reg, data, len);
     ^~~~~~~
   drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_readsb':
>> drivers/i2c/busses/i2c-zx2967.c:93:2: error: implicit declaration of function 'readsb' [-Werror=implicit-function-declaration]
     readsb(i2c->reg_base + reg, data, len);
     ^~~~~~
   cc1: some warnings being treated as errors

It's caused by that writesb/readsb are unavailable on IA64 architecture.
Let's drop COMPILE_TEST dependency to avoid the build issue.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang June 27, 2017, 7:59 p.m. UTC | #1 
On Sat, Jun 24, 2017 at 10:25:26PM +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
> 
> 0-DAY kernel test reports the following build issue on IA64 architecture
> with allmodconfig.
> 
>    drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_writesb':
> >> drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' [-Werror=implicit-function-declaration]
>      writesb(i2c->reg_base + reg, data, len);
>      ^~~~~~~
>    drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_readsb':
> >> drivers/i2c/busses/i2c-zx2967.c:93:2: error: implicit declaration of function 'readsb' [-Werror=implicit-function-declaration]
>      readsb(i2c->reg_base + reg, data, len);
>      ^~~~~~
>    cc1: some warnings being treated as errors
> 
> It's caused by that writesb/readsb are unavailable on IA64 architecture.
> Let's drop COMPILE_TEST dependency to avoid the build issue.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Applied to for-next, thanks!
diff mbox

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index ec1f305294a6..a7bc042fe502 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1262,7 +1262,7 @@  config I2C_OPAL
 
 config I2C_ZX2967
 	tristate "ZTE ZX2967 I2C support"
-	depends on ARCH_ZX || COMPILE_TEST
+	depends on ARCH_ZX
 	default y
 	help
 	  Selecting this option will add ZX2967 I2C driver.