diff mbox

[v1,1/1] i2c: designware-pci: clarify a comment for Merrifield

Message ID 1466367716-89939-1-git-send-email-andriy.shevchenko@linux.intel.com
State Superseded
Headers show

Commit Message

Andy Shevchenko June 19, 2016, 8:21 p.m. UTC
There are more than 7 busses, but only 7 are user visible. Update comment
accordingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Jarkko Nikula June 20, 2016, 6:47 a.m. UTC | #1
On 06/19/2016 11:21 PM, Andy Shevchenko wrote:
> There are more than 7 busses, but only 7 are user visible. Update comment
> accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index b66c31a..7c5a340 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -125,10 +125,10 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
>  static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
>  {
>  	/*
> -	 * On Intel Merrifield the i2c busses are enumerated [1..7]. So, we add
> -	 * 1 to shift the default range. Besides that the first PCI slot
> -	 * provides 4 functions, that's why we have to add 0 to the head slot
> -	 * and 4 to the tail one.
> +	 * On Intel Merrifield the user visible i2c busses are enumerated
> +	 * [1..7]. So, we add 1 to shift the default range. Besides that the
> +	 * first PCI slot provides 4 functions, that's why we have to add 0 to
> +	 * the fisrt slot and 4 to the next one.

typo ->     ---^

Otherwise

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index b66c31a..7c5a340 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -125,10 +125,10 @@  static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
 static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
 {
 	/*
-	 * On Intel Merrifield the i2c busses are enumerated [1..7]. So, we add
-	 * 1 to shift the default range. Besides that the first PCI slot
-	 * provides 4 functions, that's why we have to add 0 to the head slot
-	 * and 4 to the tail one.
+	 * On Intel Merrifield the user visible i2c busses are enumerated
+	 * [1..7]. So, we add 1 to shift the default range. Besides that the
+	 * first PCI slot provides 4 functions, that's why we have to add 0 to
+	 * the fisrt slot and 4 to the next one.
 	 */
 	switch (PCI_SLOT(pdev->devfn)) {
 	case 8: