| Message ID | 1465996923-76230-1-git-send-email-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Rejected |
| Headers | show |
Hi Andy, On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote: > The IP seems not used outside of x86 world, so, make it depend on CONFIG_X86. I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH mainboard.) So, nack, sorry. However I'd be OK with: depends on X86 || IA64 || COMPILE_TEST > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/i2c/busses/Kconfig | 4 ++-- > drivers/i2c/busses/i2c-i801.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index f167021..78609ad 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -89,8 +89,8 @@ config I2C_HIX5HD2 > > config I2C_I801 > tristate "Intel 82801 (ICH/PCH)" > - depends on PCI > - select CHECK_SIGNATURE if X86 && DMI > + depends on X86 && PCI > + select CHECK_SIGNATURE if DMI > help > If you say yes to this option, support will be included > for the Intel 801 family of mainboard I2C interfaces. Specifically, > the following diff --git a/drivers/i2c/busses/i2c-i801.c > b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = { > > MODULE_DEVICE_TABLE(pci, i801_ids); > > -#if defined CONFIG_X86 && defined CONFIG_DMI > +#ifdef CONFIG_DMI > static unsigned char apanel_addr; > > /* Scan the system ROM for the signature "FJKEYINF" */ > @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct > i801_priv *priv) #else > static void __init input_apanel_init(void) {} > static void i801_probe_optional_slaves(struct i801_priv *priv) {} > -#endif /* CONFIG_X86 && CONFIG_DMI */ > +#endif /* CONFIG_DMI */ > > #if (defined CONFIG_I2C_MUX_GPIO || defined > CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote: > Hi Andy, > > On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote: > > The IP seems not used outside of x86 world, so, make it depend on > > CONFIG_X86. > > I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH > mainboard.) So, nack, sorry. However I'd be OK with: > > depends on X86 || IA64 || COMPILE_TEST I don't like this. Anyway it's good to know that module is used somewhere else. Thanks. > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/i2c/busses/Kconfig | 4 ++-- > > drivers/i2c/busses/i2c-i801.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index f167021..78609ad 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -89,8 +89,8 @@ config I2C_HIX5HD2 > > > > config I2C_I801 > > tristate "Intel 82801 (ICH/PCH)" > > - depends on PCI > > - select CHECK_SIGNATURE if X86 && DMI > > + depends on X86 && PCI > > + select CHECK_SIGNATURE if DMI > > help > > If you say yes to this option, support will be included > > for the Intel 801 family of mainboard I2C interfaces. Specifically, > > the following diff --git a/drivers/i2c/busses/i2c-i801.c > > b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644 > > --- a/drivers/i2c/busses/i2c-i801.c > > +++ b/drivers/i2c/busses/i2c-i801.c > > @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = { > > > > MODULE_DEVICE_TABLE(pci, i801_ids); > > > > -#if defined CONFIG_X86 && defined CONFIG_DMI > > +#ifdef CONFIG_DMI > > static unsigned char apanel_addr; > > > > /* Scan the system ROM for the signature "FJKEYINF" */ > > @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct > > i801_priv *priv) #else > > static void __init input_apanel_init(void) {} > > static void i801_probe_optional_slaves(struct i801_priv *priv) {} > > -#endif /* CONFIG_X86 && CONFIG_DMI */ > > +#endif /* CONFIG_DMI */ > > > > #if (defined CONFIG_I2C_MUX_GPIO || defined > > CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI > >
On Fri, 17 Jun 2016 12:31:35 +0300, Andy Shevchenko wrote: > On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote: > > Hi Andy, > > > > On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote: > > > The IP seems not used outside of x86 world, so, make it depend on > > > CONFIG_X86. > > > > I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH > > mainboard.) So, nack, sorry. However I'd be OK with: > > > > depends on X86 || IA64 || COMPILE_TEST > > I don't like this. (...) May I ask why? > Anyway it's good to know that module is used > somewhere else. Thanks. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > drivers/i2c/busses/Kconfig | 4 ++-- > > > drivers/i2c/busses/i2c-i801.c | 4 ++-- > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > > index f167021..78609ad 100644 > > > --- a/drivers/i2c/busses/Kconfig > > > +++ b/drivers/i2c/busses/Kconfig > > > @@ -89,8 +89,8 @@ config I2C_HIX5HD2 > > > > > > config I2C_I801 > > > tristate "Intel 82801 (ICH/PCH)" > > > - depends on PCI > > > - select CHECK_SIGNATURE if X86 && DMI > > > + depends on X86 && PCI > > > + select CHECK_SIGNATURE if DMI > > > help > > > If you say yes to this option, support will be included > > > for the Intel 801 family of mainboard I2C interfaces. Specifically, > > > the following diff --git a/drivers/i2c/busses/i2c-i801.c > > > b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644 > > > --- a/drivers/i2c/busses/i2c-i801.c > > > +++ b/drivers/i2c/busses/i2c-i801.c > > > @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = { > > > > > > MODULE_DEVICE_TABLE(pci, i801_ids); > > > > > > -#if defined CONFIG_X86 && defined CONFIG_DMI > > > +#ifdef CONFIG_DMI > > > static unsigned char apanel_addr; > > > > > > /* Scan the system ROM for the signature "FJKEYINF" */ > > > @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct > > > i801_priv *priv) #else > > > static void __init input_apanel_init(void) {} > > > static void i801_probe_optional_slaves(struct i801_priv *priv) {} > > > -#endif /* CONFIG_X86 && CONFIG_DMI */ > > > +#endif /* CONFIG_DMI */ > > > > > > #if (defined CONFIG_I2C_MUX_GPIO || defined > > > CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2016-06-17 at 20:59 +0200, Jean Delvare wrote: > On Fri, 17 Jun 2016 12:31:35 +0300, Andy Shevchenko wrote: > > On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote: > > > depends on X86 || IA64 || COMPILE_TEST > > > > I don't like this. (...) > > May I ask why? From my point of view it's not scalable. If new arch comes you have to add it here.
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index f167021..78609ad 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -89,8 +89,8 @@ config I2C_HIX5HD2 config I2C_I801 tristate "Intel 82801 (ICH/PCH)" - depends on PCI - select CHECK_SIGNATURE if X86 && DMI + depends on X86 && PCI + select CHECK_SIGNATURE if DMI help If you say yes to this option, support will be included for the Intel 801 family of mainboard I2C interfaces. Specifically, the following diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = { MODULE_DEVICE_TABLE(pci, i801_ids); -#if defined CONFIG_X86 && defined CONFIG_DMI +#ifdef CONFIG_DMI static unsigned char apanel_addr; /* Scan the system ROM for the signature "FJKEYINF" */ @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct i801_priv *priv) #else static void __init input_apanel_init(void) {} static void i801_probe_optional_slaves(struct i801_priv *priv) {} -#endif /* CONFIG_X86 && CONFIG_DMI */ +#endif /* CONFIG_DMI */ #if (defined CONFIG_I2C_MUX_GPIO || defined CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
The IP seems not used outside of x86 world, so, make it depend on CONFIG_X86. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/Kconfig | 4 ++-- drivers/i2c/busses/i2c-i801.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)