From patchwork Fri Jul 10 05:07:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ellen Wang X-Patchwork-Id: 493636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 918BF1402BB for ; Fri, 10 Jul 2015 15:08:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b=ehJFvkUQ; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751522AbbGJFIJ (ORCPT ); Fri, 10 Jul 2015 01:08:09 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:34786 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbGJFII (ORCPT ); Fri, 10 Jul 2015 01:08:08 -0400 Received: by pdbep18 with SMTP id ep18so177592128pdb.1 for ; Thu, 09 Jul 2015 22:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=FNRKFmiU5Ra63xYitZ0FAFNJfuaHsuy4CFjqE8o3t1Y=; b=ehJFvkUQarnRIr4sLMYhWZ1DKvfnwv1ae4bNY0+fR9Xdatv2mFCSOJUlh0bFpAeJX5 upizRqcd2qsng4ixr2mKJp4DwY+lqrQpHTYwzAKWdp33N/vSnbHd8w0cL+KPreslCCxs QWoSiBlKCPBB/CXKMmr9f3EFOeNUUvwoFHVFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FNRKFmiU5Ra63xYitZ0FAFNJfuaHsuy4CFjqE8o3t1Y=; b=fLYeUxXsXWREI+q08rc9ggemL39Hn6xKWbcB6cC5wdHLyXL8G1GyOj0QP4y8w5dLbd D1Fo0hU0xAVjcgv9HtFURfXqdPh3noXUI81RsB2Ht5du8n7x0CDQRv6nYi+1L8P1HQDJ 6FcwYzMnE9rz3GyOSrJ/VpTqevU6Hb+WQyi+M/Uk9QSM/pw2C6f0qx3owJWkmp9H2onN /ox1o18V4N2++oAt8D6x1QppH5heykVax5XHQq/J4yMeusM7wgtEr5wot1KqZjGjHwyS lORyIRJyVhJUxNWwAv3RdlFZmE/BwxUuSau2iGohaJ0Rd715BGJqE+un4+gNSqUhMX0o 0uNA== X-Gm-Message-State: ALoCoQkfjyL1Ens+9IClpo+G4W1UJyBWQWhFEOFW0XG0dt57ujKJO+UIGE2Dp77UrCUc2WNtHjaU X-Received: by 10.66.66.173 with SMTP id g13mr38926333pat.155.1436504887788; Thu, 09 Jul 2015 22:08:07 -0700 (PDT) Received: from monster-01.cumulusnetworks.com ([216.129.126.126]) by smtp.gmail.com with ESMTPSA id bx8sm7911604pab.38.2015.07.09.22.08.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 22:08:07 -0700 (PDT) From: Ellen Wang To: borneo.antonio@gmail.com, dbarksdale@uplogix.com, jkosina@suse.cz, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Cc: ellen@cumulusnetworks.com Subject: [PATCH v1] HID: cp2112: fix I2C_SMBUS_BYTE write Date: Thu, 9 Jul 2015 22:07:51 -0700 Message-Id: <1436504871-3676-1-git-send-email-ellen@cumulusnetworks.com> X-Mailer: git-send-email 1.9.1 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org When doing an I2C_SMBUS_BYTE write (one byte write, no address), the data to be written is in "command" not "data->byte". --- drivers/hid/hid-cp2112.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index a3703b8..7afc3fc 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -606,7 +606,7 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr, if (I2C_SMBUS_READ == read_write) count = cp2112_read_req(buf, addr, read_length); else - count = cp2112_write_req(buf, addr, data->byte, NULL, + count = cp2112_write_req(buf, addr, command, NULL, 0); break; case I2C_SMBUS_BYTE_DATA: