diff mbox

i2c: xgene-slimpro: Fix missing mbox_free_channel call in probe error path

Message ID 1435633726.14315.1.camel@ingics.com
State Accepted
Headers show

Commit Message

Axel Lin June 30, 2015, 3:08 a.m. UTC 
Free requested mailbox channel before return error.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/i2c/busses/i2c-xgene-slimpro.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wolfram Sang July 9, 2015, 8:14 p.m. UTC | #1 
On Tue, Jun 30, 2015 at 11:08:46AM +0800, Axel Lin wrote:
> Free requested mailbox channel before return error.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Applied to for-next, thanks!
Wolfram Sang July 9, 2015, 8:17 p.m. UTC | #2 
On Thu, Jul 09, 2015 at 10:14:22PM +0200, Wolfram Sang wrote:
> On Tue, Jun 30, 2015 at 11:08:46AM +0800, Axel Lin wrote:
> > Free requested mailbox channel before return error.
> > 
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Applied to for-next, thanks!

for-current, I mean. Sorry for the noise.
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index dcca707..1c9cb65a 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -419,6 +419,7 @@  static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
 	rc = i2c_add_adapter(adapter);
 	if (rc) {
 		dev_err(&pdev->dev, "Adapter registeration failed\n");
+		mbox_free_channel(ctx->mbox_chan);
 		return rc;
 	}