| Message ID | 1429112927-19789-1-git-send-email-linux@roeck-us.net |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Apr 15, 2015 at 08:48:47AM -0700, Guenter Roeck wrote: > Fix: > > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': > drivers/i2c/busses/i2c-jz4780.c:181:2: error: > implicit declaration of function 'readw' > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': > drivers/i2c/busses/i2c-jz4780.c:187:2: error: > implicit declaration of function 'writew' > > seen with sparc64:allmodconfig and m68k:allmodconfig. > > The driver has to include linux/io.h. > > Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver > for Ingenic JZ4780") > Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c index ce1d69324169..19b2d689a5ef 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c @@ -23,6 +23,7 @@ #include <linux/i2c.h> #include <linux/init.h> #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/platform_device.h>
Fix: drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' seen with sparc64:allmodconfig and m68k:allmodconfig. The driver has to include linux/io.h. Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver for Ingenic JZ4780") Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- v2: HAS_IOMEM dependency already existed Fixed include file order drivers/i2c/busses/i2c-jz4780.c | 1 + 1 file changed, 1 insertion(+)