From patchwork Mon Mar 16 23:28:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jakub_Kici=C5=84ski?= X-Patchwork-Id: 450811 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C43F91400A0 for ; Tue, 17 Mar 2015 10:35:40 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=neutral reason="verification failed; unprotected key/testing" header.d=wp.pl header.i=@wp.pl header.b=E8O9ENsW; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932721AbbCPXfi (ORCPT ); Mon, 16 Mar 2015 19:35:38 -0400 Received: from mx4.wp.pl ([212.77.101.12]:53782 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932875AbbCPXfg (ORCPT ); Mon, 16 Mar 2015 19:35:36 -0400 Received: (wp-smtpd smtp.wp.pl 29154 invoked from network); 17 Mar 2015 00:28:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1426548534; bh=uyHXwJn1U4hqdGJnfhmAIGY0semnDnxJD0ik/5IfCsU=; h=From:To:Cc:Subject; b=E8O9ENsWNyLV2eZz0qslyt5orfvyYyv95zwPuCmTGxES0yt9lA5Ga3hjOHb290UuT HQZ+mG16TjXFkjlh4yHhRTUnBYpLtLGE7moSxKNVCuwp5yt4nh+pFK1+nofN/bF4wN AFTQDIiIIWY9qnJXVt1SPkqb6hrcDVbxlmbsHhYg= Received: from 89-69-164-220.dynamic.chello.pl (HELO north.moorray.no-ip.org) (moorray3@[89.69.164.220]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 17 Mar 2015 00:28:53 +0100 Received: by north.moorray.no-ip.org (sSMTP sendmail emulation); Tue, 17 Mar 2015 00:28:53 +0100 From: Jakub Kicinski To: Greg Kroah-Hartman Cc: Jon Ringle , linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org, =?UTF-8?q?Karol=20D=C4=99bog=C3=B3rski?= , Jakub Kicinski Subject: [PATCH 1/4] sc16is7xx: remove ports on probe error path Date: Tue, 17 Mar 2015 00:28:46 +0100 Message-Id: <1426548529-21738-2-git-send-email-moorray3@wp.pl> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426548529-21738-1-git-send-email-moorray3@wp.pl> References: <1426548529-21738-1-git-send-email-moorray3@wp.pl> X-WP-DKIM-Status: good (id: wp.pl) X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [kePE] Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Jakub Kicinski If ports are not explicitly removed on the error path the device will not get properly unregistered leaving /dev/ttySC* nodes in the filesystem. Signed-off-by: Jakub Kicinski Signed-off-by: Jon Ringle --- drivers/tty/serial/sc16is7xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index df9a384dfbda..11bb44039a57 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1120,6 +1120,9 @@ static int sc16is7xx_probe(struct device *dev, if (!ret) return 0; + for (i = 0; i < s->uart.nr; i++) + uart_remove_one_port(&s->uart, &s->p[i].port); + mutex_destroy(&s->mutex); #ifdef CONFIG_GPIOLIB