From patchwork Fri Aug 23 09:30:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 269363 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AFFEA2C0089 for ; Fri, 23 Aug 2013 19:30:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236Ab3HWJan (ORCPT ); Fri, 23 Aug 2013 05:30:43 -0400 Received: from sauhun.de ([89.238.76.85]:49378 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137Ab3HWJam (ORCPT ); Fri, 23 Aug 2013 05:30:42 -0400 Received: from p5b3874d3.dip0.t-ipconnect.de ([91.56.116.211]:60857 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1VCnhW-0003WN-U4; Fri, 23 Aug 2013 11:30:39 +0200 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Seth Heasley , Neil Horman Subject: [PATCH] i2c: ismt: add error return code in probe() Date: Fri, 23 Aug 2013 11:30:14 +0200 Message-Id: <1377250230-19166-1-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 1.7.10.4 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Return error code in the error case, and not success. Signed-off-by: Wolfram Sang Acked-by: Neil Horman --- Error code itself is probably not perfect, but consistent :/ Improving the return values might be considered for a later patch. Based on 3.11-rc6. drivers/i2c/busses/i2c-ismt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c index cd82eb4..8ed79a0 100644 --- a/drivers/i2c/busses/i2c-ismt.c +++ b/drivers/i2c/busses/i2c-ismt.c @@ -879,6 +879,7 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id) DMA_BIT_MASK(32)) != 0)) { dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n", pdev); + err = -ENODEV; goto fail; } }