From patchwork Tue Aug 1 06:44:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 796101 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fEspAeuK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xM6J139GFz9tWN for ; Tue, 1 Aug 2017 16:44:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101AbdHAGos (ORCPT ); Tue, 1 Aug 2017 02:44:48 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36294 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdHAGor (ORCPT ); Tue, 1 Aug 2017 02:44:47 -0400 Received: by mail-pg0-f65.google.com with SMTP id y129so1118564pgy.3; Mon, 31 Jul 2017 23:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=71qcSPgzIzVqh3+JOMF1Ch+jUa8ZaRgmnMyeyNi1lBA=; b=fEspAeuKSecj9EUAX+yqou3eMCZsQ5v3f9lF063pRphVZ353Azzo4y0nhdvPRe5YwK 5V5vzt6xspDSuvV2i6xg5dHr5opPtQZqHi4goKPok1RhDIPRoX8gP1yW1A2DyYp+/FpE xalhD4QTrzjzZWuikYjev/z/Cz0FhEEzNGDJNf470k59SSEHXVMzOOH848wJjE/j45cF k5BIfQ1mvaQkTC5/R2xP3rKYyvclIzvlr+fU7Q1I0muF/yA9npWIxJRGq66oqxtlxr+y ruYGDiUiJb//6kt4twyUTKLoq5QPg1L1kS+vJLLLZ5OGE7piQQSqUcbNOrwyHSAd+Nx7 fcMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=71qcSPgzIzVqh3+JOMF1Ch+jUa8ZaRgmnMyeyNi1lBA=; b=YtdcHZeqvgVrwCGnmey+rtGqCfeL0atijdC/WGf8aL3gTtHHoWbElDwMNTigeB/F1a 6r76ZjZ564d8ZLi3NjmENdiouSLDfPh6AAFGttG+im9NWw+kuuu1uLHnImcvzFRxpxep O+MA6aoR2qzWY+Btl2jZZr2j0hruKCxrqVAH9D9EZkQMUs4lp8OmqijO8HRrtX8q/yRd 2W5Q1NIB8A2ssEohCtbTCUf/QwR5TArRZg2I/7lQVq9bToe2uKaHE5nH3cT4UMRToDal SnuR6xxLiKBKcpChgXoZAqoQlmBzyqHK5JoiNy7q/GO21PMvHuJR5to9bANj+otPs7pK 3cYQ== X-Gm-Message-State: AIVw113UhEsq8o6hI+WSoLh6iUBuh+fo9ZxpCmf07X9e4tM8//WByy8M kJeAFueo0k+RfQ== X-Received: by 10.98.33.212 with SMTP id o81mr17986382pfj.50.1501569886678; Mon, 31 Jul 2017 23:44:46 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id f15sm54782025pga.5.2017.07.31.23.44.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 31 Jul 2017 23:44:46 -0700 (PDT) From: Arvind Yadav To: grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, linus.walleij@linaro.org Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] gpio: omap : Add missing clk_unprepare(). Date: Tue, 1 Aug 2017 12:14:31 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org omap_gpio_probe() can fail here and we must disable clock. Signed-off-by: Arvind Yadav Reviewed-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index f8c550de..dbf869f 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1247,6 +1247,8 @@ static int omap_gpio_probe(struct platform_device *pdev) if (ret) { pm_runtime_put_sync(dev); pm_runtime_disable(dev); + if (bank->dbck_flag) + clk_unprepare(bank->dbck); return ret; }