Message ID | Y1FgAAHJu/cVNAIC@black.fi.intel.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] intel-pinctrl for 6.1-1 | expand |
On Thu, Oct 20, 2022 at 4:58 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Hi Linux pin control maintainers, > > A bunch of cleanups of the pin control and GPIO headers. It has been a couple > of days in Linux Next without any major issue reported, a few fixes are already > incorporated in the respective patches. The idea is that pin control and GPIO > subsystems take it now and we will continue from this for all new code. > > Linus, Bart, please pull to your trees. > The tag is signed and can be considered as immutable. > > Thanks, > > With Best Regards, > Andy Shevchenko > > The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: > > Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git tags/intel-pinctrl-v6.1-1 > > for you to fetch changes up to 1053f6a58766ac8eadcb72630262a5a454048479: > > pinctrl: Clean up headers (2022-10-19 18:08:45 +0300) > > ---------------------------------------------------------------- > intel-pinctrl for v6.1-1 > > * Add missing and remove unused headers in pin control and GPIO drivers > * Revise the pin control and GPIO headers > > ---------------------------------------------------------------- > Andy Shevchenko (50): > gpio: aspeed: Add missing header(s) > gpio: arizona: Remove unused header(s) > gpio: da9052: Remove unused header(s) > gpio: mockup: Add missing header(s) > gpio: pca953x: Add missing header(s) > gpio: pl061: Add missing header(s) > gpio: reg: Add missing header(s) > gpio: wm8350: Remove unused header(s) > gpio: tegra186: Add missing header(s) > gpiolib: cdev: Add missing header(s) > gpiolib: Clean up headers Can you send the GPIO changes separately? This way I don't need to pull all those pinctrl patches into the GPIO PR for the next merge window. Bartosz > media: c8sectpfe: Add missing header(s) > pinctrl: actions: Add missing header(s) > pinctrl: aspeed: Add missing header(s) > pinctrl: at91: Add missing header(s) > pinctrl: axp209: Add missing header(s) > pinctrl: bcm: Add missing header(s) > pinctrl: bm1880: Add missing header(s) > pinctrl: cygnus-mux: Add missing header(s) > pinctrl: gemini: Add missing header(s) > pinctrl: imx: Add missing header(s) > pinctrl: ingenic: Add missing header(s) > pinctrl: k210: Add missing header(s) > pinctrl: lochnagar: Add missing header(s) > pinctrl: lpc18xx: Add missing header(s) > pinctrl: mediatek: Add missing header(s) > pinctrl: microchip-sgpio: Add missing header(s) > pinctrl: mvebu: Add missing header(s) > pinctrl: npcm7xx: Add missing header(s) > pinctrl: ocelot: Add missing header(s) > pinctrl: qcom: Add missing header(s) > pinctrl: renesas: Add missing header(s) > pinctrl: samsung: Add missing header(s) > pinctrl: single: Add missing header(s) > pinctrl: spear: Add missing header(s) > pinctrl: sprd: Add missing header(s) > pinctrl: st: Add missing header(s) > pinctrl: starfive: Add missing header(s) > pinctrl: stm32: Add missing header(s) > pinctrl: stmfx: Add missing header(s) > pinctrl: sunxi: Add missing header(s) > pinctrl: tegra: Add missing header(s) > pinctrl: ti-iodelay: Add missing header(s) > pinctrl: uniphier: Add missing header(s) > pinctrl: zynqmp: Add missing header(s) > pinctrl: cherryview: Add missing header(s) > pinctrl: lynxpoint: Add missing header(s) > pinctrl: merrifield: Add missing header(s) > pinctrl: intel: Add missing header(s) > pinctrl: Clean up headers > > drivers/gpio/gpio-arizona.c | 5 ++-- > drivers/gpio/gpio-aspeed.c | 5 ++-- > drivers/gpio/gpio-da9052.c | 9 +++---- > drivers/gpio/gpio-mockup.c | 1 + > drivers/gpio/gpio-pca953x.c | 3 ++- > drivers/gpio/gpio-pl061.c | 15 ++++++----- > drivers/gpio/gpio-tegra186.c | 3 ++- > drivers/gpio/gpio-wm8350.c | 7 +++-- > drivers/gpio/gpiolib-acpi.h | 12 +++++++++ > drivers/gpio/gpiolib-cdev.c | 4 ++- > drivers/gpio/gpiolib-of.h | 11 +++++++- > drivers/gpio/gpiolib-sysfs.h | 2 ++ > .../platform/st/sti/c8sectpfe/c8sectpfe-core.c | 8 +++--- > drivers/pinctrl/actions/pinctrl-owl.c | 10 ++++--- > drivers/pinctrl/aspeed/pinctrl-aspeed.c | 1 + > drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 13 +++++---- > drivers/pinctrl/bcm/pinctrl-cygnus-mux.c | 9 ++++--- > drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 12 +++++---- > drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 8 +++--- > drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 8 +++--- > drivers/pinctrl/cirrus/pinctrl-lochnagar.c | 6 +++-- > drivers/pinctrl/core.c | 19 ++++++------- > drivers/pinctrl/core.h | 12 ++++++++- > drivers/pinctrl/devicetree.h | 6 +++++ > drivers/pinctrl/freescale/pinctrl-imx.c | 8 +++--- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 4 ++- > drivers/pinctrl/intel/pinctrl-cherryview.c | 6 +++-- > drivers/pinctrl/intel/pinctrl-intel.c | 6 +++-- > drivers/pinctrl/intel/pinctrl-lynxpoint.c | 6 +++-- > drivers/pinctrl/intel/pinctrl-merrifield.c | 4 ++- > drivers/pinctrl/mediatek/pinctrl-moore.c | 3 +++ > drivers/pinctrl/mediatek/pinctrl-paris.c | 5 ++++ > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 14 +++++----- > drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 11 +++++--- > drivers/pinctrl/pinconf.h | 10 +++++++ > drivers/pinctrl/pinctrl-at91-pio4.c | 10 ++++--- > drivers/pinctrl/pinctrl-at91.c | 16 ++++++----- > drivers/pinctrl/pinctrl-axp209.c | 8 +++--- > drivers/pinctrl/pinctrl-bm1880.c | 6 +++-- > drivers/pinctrl/pinctrl-gemini.c | 12 +++++---- > drivers/pinctrl/pinctrl-ingenic.c | 10 ++++--- > drivers/pinctrl/pinctrl-k210.c | 12 +++++---- > drivers/pinctrl/pinctrl-lpc18xx.c | 6 +++-- > drivers/pinctrl/pinctrl-microchip-sgpio.c | 4 ++- > drivers/pinctrl/pinctrl-ocelot.c | 10 ++++--- > drivers/pinctrl/pinctrl-single.c | 6 ++--- > drivers/pinctrl/pinctrl-st.c | 21 +++++++++------ > drivers/pinctrl/pinctrl-stmfx.c | 2 ++ > drivers/pinctrl/pinctrl-utils.h | 5 ++++ > drivers/pinctrl/pinctrl-zynqmp.c | 5 +++- > drivers/pinctrl/pinmux.c | 17 +++++++----- > drivers/pinctrl/pinmux.h | 11 ++++++++ > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 8 +++--- > drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 8 +++--- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 7 +++-- > drivers/pinctrl/renesas/pinctrl-rzn1.c | 8 ++++-- > drivers/pinctrl/renesas/pinctrl-rzv2m.c | 4 ++- > drivers/pinctrl/renesas/pinctrl.c | 8 +++--- > drivers/pinctrl/samsung/pinctrl-samsung.c | 11 ++++---- > drivers/pinctrl/spear/pinctrl-spear.c | 6 +++-- > drivers/pinctrl/sprd/pinctrl-sprd.c | 6 +++-- > drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 3 +++ > drivers/pinctrl/stm32/pinctrl-stm32.c | 16 ++++++----- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 18 +++++++------ > drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 6 +++-- > drivers/pinctrl/tegra/pinctrl-tegra.c | 6 +++-- > drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 8 +++--- > drivers/pinctrl/uniphier/pinctrl-uniphier-core.c | 8 +++--- > include/linux/gpio.h | 2 +- > include/linux/gpio/aspeed.h | 4 +++ > include/linux/gpio/driver.h | 2 +- > include/linux/gpio/gpio-reg.h | 4 +++ > include/linux/gpio/machine.h | 1 - > include/linux/pinctrl/consumer.h | 31 ++++++++++------------ > include/linux/pinctrl/devinfo.h | 6 +++-- > include/linux/pinctrl/machine.h | 8 +++--- > include/linux/pinctrl/pinconf-generic.h | 23 +++++++++------- > include/linux/pinctrl/pinctrl.h | 18 ++++++------- > include/linux/pinctrl/pinmux.h | 5 ++-- > 79 files changed, 428 insertions(+), 234 deletions(-) > > -- > With Best Regards, > Andy Shevchenko > >
On Thu, Oct 20, 2022 at 07:31:23PM +0200, Bartosz Golaszewski wrote: > On Thu, Oct 20, 2022 at 4:58 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > Hi Linux pin control maintainers, > > > > A bunch of cleanups of the pin control and GPIO headers. It has been a couple > > of days in Linux Next without any major issue reported, a few fixes are already > > incorporated in the respective patches. The idea is that pin control and GPIO > > subsystems take it now and we will continue from this for all new code. > > > > Linus, Bart, please pull to your trees. > > The tag is signed and can be considered as immutable. > > > > Thanks, > > > > With Best Regards, > > Andy Shevchenko > > > > The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: > > > > Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git tags/intel-pinctrl-v6.1-1 > > > > for you to fetch changes up to 1053f6a58766ac8eadcb72630262a5a454048479: > > > > pinctrl: Clean up headers (2022-10-19 18:08:45 +0300) > > > > ---------------------------------------------------------------- > > intel-pinctrl for v6.1-1 > > > > * Add missing and remove unused headers in pin control and GPIO drivers > > * Revise the pin control and GPIO headers > > > > ---------------------------------------------------------------- > > Andy Shevchenko (50): > > gpio: aspeed: Add missing header(s) > > gpio: arizona: Remove unused header(s) > > gpio: da9052: Remove unused header(s) > > gpio: mockup: Add missing header(s) > > gpio: pca953x: Add missing header(s) > > gpio: pl061: Add missing header(s) > > gpio: reg: Add missing header(s) > > gpio: wm8350: Remove unused header(s) > > gpio: tegra186: Add missing header(s) > > gpiolib: cdev: Add missing header(s) > > gpiolib: Clean up headers > > Can you send the GPIO changes separately? This way I don't need to > pull all those pinctrl patches into the GPIO PR for the next merge > window. Some of them, but not all, if that what you wish. I.o.w. a couple of the GPIO changes must be part of pin control series.
On Thu, Oct 20, 2022 at 08:43:18PM +0300, Andy Shevchenko wrote: > On Thu, Oct 20, 2022 at 07:31:23PM +0200, Bartosz Golaszewski wrote: > > On Thu, Oct 20, 2022 at 4:58 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: ... > > Can you send the GPIO changes separately? This way I don't need to > > pull all those pinctrl patches into the GPIO PR for the next merge > > window. > > Some of them, but not all, if that what you wish. > I.o.w. a couple of the GPIO changes must be part of pin control series. And I just realized that if any of new GPIO code will appear with the wrong headers, there will be an inconsistent state. That said, I prefer this PR is go as is.
On Thu, Oct 20, 2022 at 7:44 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, Oct 20, 2022 at 08:43:18PM +0300, Andy Shevchenko wrote: > > On Thu, Oct 20, 2022 at 07:31:23PM +0200, Bartosz Golaszewski wrote: > > > On Thu, Oct 20, 2022 at 4:58 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > ... > > > > Can you send the GPIO changes separately? This way I don't need to > > > pull all those pinctrl patches into the GPIO PR for the next merge > > > window. > > > > Some of them, but not all, if that what you wish. > > I.o.w. a couple of the GPIO changes must be part of pin control series. > > And I just realized that if any of new GPIO code will appear with the wrong > headers, there will be an inconsistent state. That said, I prefer this PR is > go as is. Bart are you fine with pulling this as-is? (I am.) Last merge window I pulled in a big I2C cleanup (remove to return void on 6 million drivers) and it was fine, my diffstat looked horrible but Torvalds accepted it anyway I just mentioned it to him. I think there is a way to shave off the irrelevant stuff from the diffstat, and I think Andy even told me how to do this but can't find/remember the git method used. Yours, Linus Walleij
On Fri, Oct 21, 2022 at 10:02:35AM +0200, Linus Walleij wrote: > On Thu, Oct 20, 2022 at 7:44 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Oct 20, 2022 at 08:43:18PM +0300, Andy Shevchenko wrote: > > > On Thu, Oct 20, 2022 at 07:31:23PM +0200, Bartosz Golaszewski wrote: > > > > On Thu, Oct 20, 2022 at 4:58 PM Andy Shevchenko > > > > <andriy.shevchenko@linux.intel.com> wrote: ... > > > > Can you send the GPIO changes separately? This way I don't need to > > > > pull all those pinctrl patches into the GPIO PR for the next merge > > > > window. > > > > > > Some of them, but not all, if that what you wish. > > > I.o.w. a couple of the GPIO changes must be part of pin control series. > > > > And I just realized that if any of new GPIO code will appear with the wrong > > headers, there will be an inconsistent state. That said, I prefer this PR is > > go as is. > > Bart are you fine with pulling this as-is? (I am.) Hold on a bit, I have to rebuild a whole kernel to test if I missed something (it's already clear I missed lantiq patch, now in my branch, but obviously not in that tag, since I called it immutable). > Last merge window I pulled in a big I2C cleanup (remove to return void on > 6 million drivers) and it was fine, my diffstat looked horrible but Torvalds > accepted it anyway I just mentioned it to him. > > I think there is a way to shave off the irrelevant stuff from the diffstat, > and I think Andy even told me how to do this but can't find/remember the > git method used. IIRC when you create a pull request, do it from the certain base, like origin/master..HEAD~0 and it will drop the applied changes automatically. But I don't remember this by heart, so need to refresh my memories as well.
On Sun, Oct 23, 2022 at 10:04 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Fri, Oct 21, 2022 at 10:02:35AM +0200, Linus Walleij wrote: > > Bart are you fine with pulling this as-is? (I am.) > > Hold on a bit, I have to rebuild a whole kernel to test if I missed something > (it's already clear I missed lantiq patch, now in my branch, but obviously not > in that tag, since I called it immutable). OK I hold my horses waiting for your confirmation, I expect to pull the immutable branch once it is confirmed stable. Yours, Linus Walleij
On Mon, Oct 24, 2022 at 09:16:28AM +0200, Linus Walleij wrote: > On Sun, Oct 23, 2022 at 10:04 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Oct 21, 2022 at 10:02:35AM +0200, Linus Walleij wrote: > > > > Bart are you fine with pulling this as-is? (I am.) > > > > Hold on a bit, I have to rebuild a whole kernel to test if I missed something > > (it's already clear I missed lantiq patch, now in my branch, but obviously not > > in that tag, since I called it immutable). > > OK I hold my horses waiting for your confirmation, I expect to > pull the immutable branch once it is confirmed stable. I hope I found all places under drivers/pinctrl to fix, but let's wait a couple of days so Linux Next and CIs may have a chance to exercise it a bit.
On Mon, Oct 24, 2022 at 06:06:52PM +0300, Andy Shevchenko wrote: > On Mon, Oct 24, 2022 at 09:16:28AM +0200, Linus Walleij wrote: > > On Sun, Oct 23, 2022 at 10:04 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > On Fri, Oct 21, 2022 at 10:02:35AM +0200, Linus Walleij wrote: ... > > > > Bart are you fine with pulling this as-is? (I am.) > > > > > > Hold on a bit, I have to rebuild a whole kernel to test if I missed something > > > (it's already clear I missed lantiq patch, now in my branch, but obviously not > > > in that tag, since I called it immutable). > > > > OK I hold my horses waiting for your confirmation, I expect to > > pull the immutable branch once it is confirmed stable. > > I hope I found all places under drivers/pinctrl to fix, but let's wait > a couple of days so Linux Next and CIs may have a chance to exercise it > a bit. New PR has been sent.