From patchwork Wed Jul 6 13:15:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 645296 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rl1TY0HpDz9sCY for ; Wed, 6 Jul 2016 23:15:45 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=qcm/33rq; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078AbcGFNPn (ORCPT ); Wed, 6 Jul 2016 09:15:43 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35047 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbcGFNPn (ORCPT ); Wed, 6 Jul 2016 09:15:43 -0400 Received: by mail-vk0-f65.google.com with SMTP id m127so504789vkb.2; Wed, 06 Jul 2016 06:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dmsrSDlKmhvqfpm9w5s+BGNbGqKkCrlStxXdyIH4SRo=; b=qcm/33rqlNNMzkzCbJBGFiD/HI7Px0shwYRkjZ4eoqQd6OyxudfzJH4wCjQtmlMp31 GFA+BKLxPGPHj4eNShe2sVX41D0EpeK+01WQHtiM0kKos6ApfpUrBgwecqIFIbtKYSNk okKyvviPOFeLgYCIzDiqXMTfCItmCKXhWJLtA3klWvup+x1JaWgSqvMtkN6c+Y+2+r2H pPCG/heLQq8mLcT3bRrPaCHVJTnCozz/IgMEPhLHqgWNWJj16CXpGYpcdlx52T1HzUwu A1r33QhJ2IpcpjolGNklSNMkHCFJcIK29qcvKBTe3z70NMmNfeFz1DBaVynHRK8an7Df D8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dmsrSDlKmhvqfpm9w5s+BGNbGqKkCrlStxXdyIH4SRo=; b=IJF3qDXTxGrvkAQhkVyFRItBW22JIHgSB0Kgp1kmELIiu95hpBJFb6Iq8FvI5FZbhH s1pvrF/7u+fuYt2o0vvw5FNcVaLjoJ+yznOO61DauOMmaUBz6Kh/EG/K9xLbpMV2uSby eWIoYbgQtE2WncdsLgHkb1moEGC4iwBv2WmG6peM0cyDy0CsSTTXIQqcPUPXaW0ozRJz mTKtsV4R2I7Dh0joKtIF6KY2+7p6U2TW6le3oxne77HU5yXOvGY9lkuSdyndncKTvK4r qtXeHrJkN+ebOpRgwhwiWS/mlJ5LUagrvnCLY8ZdF9IrUGtqR6TjUNlWfGnjTfTo32jM ZE1w== X-Gm-Message-State: ALyK8tLqNK5qul8LHPEIz3FDH26OpYWLGJ8lSYd2G9kaaMpzP7WGh97ngbTrtpW/zHkjsfJVLx6CxsghLqFikA== X-Received: by 10.159.36.15 with SMTP id 15mr4903444uaq.79.1467810941975; Wed, 06 Jul 2016 06:15:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.92.10 with HTTP; Wed, 6 Jul 2016 06:15:41 -0700 (PDT) In-Reply-To: <20160706125254.1663066-1-arnd@arndb.de> References: <20160706125254.1663066-1-arnd@arndb.de> From: Fabio Estevam Date: Wed, 6 Jul 2016 10:15:41 -0300 Message-ID: Subject: Re: [PATCH] pinctrl: imx21: include linux/module.h To: Arnd Bergmann Cc: Linus Walleij , Paul Gortmaker , Laxman Dewangan , "linux-gpio@vger.kernel.org" , linux-kernel Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Arnd, On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann wrote: > The pinctrl driver includes a device table, but the macro used for > declaring it is declared in a header that is not visible here: > > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror] > MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > This adds the missing include. > > Signed-off-by: Arnd Bergmann > Fixes: e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular") I think the correct fix here would be: If you agree I can send a formal patch. --- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/pinctrl/freescale/pinctrl-imx21.c +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = { .compatible = "fsl,imx21-iomuxc", }, { } }; -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); static struct platform_driver imx21_pinctrl_driver = { .driver = {