| Message ID | CAOMZO5APrVUAi+QbnLVJ61T_oJRQQDF_eLi8_HeqK=L+aVBzwQ@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Wednesday, July 6, 2016 10:15:41 AM CEST Fabio Estevam wrote: > I think the correct fix here would be: > > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = > { .compatible = "fsl,imx21-iomuxc", }, > { } > }; > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > static struct platform_driver imx21_pinctrl_driver = { > .driver = { > > > If you agree I can send a formal patch. Fine with me too. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Re: [PATCH] pinctrl: imx21: include linux/module.h] On 06/07/2016 (Wed 10:15) Fabio Estevam wrote: > Hi Arnd, > > On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > The pinctrl driver includes a device table, but the macro used for > > declaring it is declared in a header that is not visible here: > > > > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror] > > MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > > > This adds the missing include. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Fixes: e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular") > > I think the correct fix here would be: > > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = > { .compatible = "fsl,imx21-iomuxc", }, > { } > }; > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > static struct platform_driver imx21_pinctrl_driver = { > .driver = { > > > If you agree I can send a formal patch. Yes, deleting the MODULE_DEVICE_TABLE is the right fix. I'm curious why that never showed up in all the build coverage I did... Paul. -- -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote: > > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c > > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c > > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = > > { .compatible = "fsl,imx21-iomuxc", }, > > { } > > }; > > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > > > static struct platform_driver imx21_pinctrl_driver = { > > .driver = { > > > > > > If you agree I can send a formal patch. > > Yes, deleting the MODULE_DEVICE_TABLE is the right fix. I'm curious why > that never showed up in all the build coverage I did... I needed several hundred randconfig builds before hitting it, I think it's just rare because the driver is not enabled most of the time, and it's possible that the header sometimes gets included implicitly. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/pinctrl/freescale/pinctrl-imx21.c +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = { .compatible = "fsl,imx21-iomuxc", }, { } }; -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); static struct platform_driver imx21_pinctrl_driver = { .driver = {