Message ID | CACRpkdaVGwu=Bo5bxVQYZXD-k+x++SuOTApGoK2a_S-1M4Q+nQ@mail.gmail.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] pin control changes for v5.17 | expand |
On Wed, Jan 12, 2022 at 3:23 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > - There will be conflicts! Kconfig and Makefile conflicts due to > some RISC-V Starfive patches getting merged through the > SoC tree while we were tidying up the Kconfig and Makefile > (to avoid merge conflicts, heh) there is a resolution in linux-next > which was discussed and reviewed to be correct. Whoever sorted the Makefile entries (yeah, it was Andy) isn't very good at it. The broken sorting put CONFIG_PINCTRL_STMFX before CONFIG_PINCTRL_ST, and I have no idea how you can sort that way. I left the broken sorting in place, because changing the sort order in the merge would just be even *more* confusing. There may be other cases of that kind of oddity, I just happened to notice that one because the 'starfive' thing ended up having that same 'st' beginning, and I went D'Oh when trying to make sure my merge kept the ordering. The sort order is fine in the Kconfig file. Maybe some odd sorting got confused by the next non-letter character (either ')' after the config name, or '.o' of the object file name). Obviously not a big deal, but it's an oddity. Linus
The pull request you sent on Wed, 12 Jan 2022 12:23:03 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git tags/pinctrl-v5.17-1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e3084ed48fd6b661fe434da0cb36d7d6706cf27f
Thank you!
On Wed, Jan 12, 2022 at 11:09:23AM -0800, Linus Torvalds wrote: > On Wed, Jan 12, 2022 at 3:23 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > - There will be conflicts! Kconfig and Makefile conflicts due to > > some RISC-V Starfive patches getting merged through the > > SoC tree while we were tidying up the Kconfig and Makefile > > (to avoid merge conflicts, heh) there is a resolution in linux-next > > which was discussed and reviewed to be correct. > > Whoever sorted the Makefile entries (yeah, it was Andy) isn't very good at it. Indeed. Sorry for that, I will send an update for next cycle. > The broken sorting put CONFIG_PINCTRL_STMFX before CONFIG_PINCTRL_ST, > and I have no idea how you can sort that way. > > I left the broken sorting in place, because changing the sort order in > the merge would just be even *more* confusing. > > There may be other cases of that kind of oddity, I just happened to > notice that one because the 'starfive' thing ended up having that same > 'st' beginning, and I went D'Oh when trying to make sure my merge kept > the ordering. > > The sort order is fine in the Kconfig file. Maybe some odd sorting got > confused by the next non-letter character (either ')' after the config > name, or '.o' of the object file name). > > Obviously not a big deal, but it's an oddity.
On Wed, Jan 12, 2022 at 10:38:40PM +0200, Andy Shevchenko wrote: > On Wed, Jan 12, 2022 at 11:09:23AM -0800, Linus Torvalds wrote: > > On Wed, Jan 12, 2022 at 3:23 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > > > - There will be conflicts! Kconfig and Makefile conflicts due to > > > some RISC-V Starfive patches getting merged through the > > > SoC tree while we were tidying up the Kconfig and Makefile > > > (to avoid merge conflicts, heh) there is a resolution in linux-next > > > which was discussed and reviewed to be correct. > > > > Whoever sorted the Makefile entries (yeah, it was Andy) isn't very good at it. > > Indeed. Sorry for that, I will send an update for next cycle. > > > The broken sorting put CONFIG_PINCTRL_STMFX before CONFIG_PINCTRL_ST, > > and I have no idea how you can sort that way. > > > > I left the broken sorting in place, because changing the sort order in > > the merge would just be even *more* confusing. > > > > There may be other cases of that kind of oddity, I just happened to > > notice that one because the 'starfive' thing ended up having that same > > 'st' beginning, and I went D'Oh when trying to make sure my merge kept > > the ordering. I setup a little experiment, since I'm using vim, there are two possibilities to sort the selection, i.e. using internal sort and calling external !sort. Using internal gives: -obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o obj-$(CONFIG_PINCTRL_STARFIVE) += pinctrl-starfive.o +obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o Using external gives: +obj-$(CONFIG_PINCTRL_STARFIVE) += pinctrl-starfive.o obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o -obj-$(CONFIG_PINCTRL_STARFIVE) += pinctrl-starfive.o Now you may easily see what happened.
On Wed, Jan 12, 2022 at 12:57 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Now you may easily see what happened. I still have no idea how any sort wouldn't sort that CONFIG_PINCTRL_ST line first, since even if it's about the following characters, both ')' and '.' would normally sort before any letters at least in ASCII. So I can only assume it's something that takes the locale into account in odd ways, or just has some special rules for non-alpha sorting. But I don't find it in myself to care apart from noting the strangeness of it all. Linus