From patchwork Mon Nov 6 14:12:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Henrik Juul Pedersen X-Patchwork-Id: 834763 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=liab-dk.20150623.gappssmtp.com header.i=@liab-dk.20150623.gappssmtp.com header.b="YG5i/aHC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yVvdt5s82z9s74 for ; Tue, 7 Nov 2017 01:12:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbdKFOMe (ORCPT ); Mon, 6 Nov 2017 09:12:34 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:56524 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbdKFOMd (ORCPT ); Mon, 6 Nov 2017 09:12:33 -0500 Received: by mail-lf0-f66.google.com with SMTP id 90so10627258lfs.13 for ; Mon, 06 Nov 2017 06:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=liab-dk.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=UiUTdmhjJlgkUyIvVoReMpiQZ40G8tIY8GthMHJOxCY=; b=YG5i/aHCAgf1C8MmXnPyH1MAN88oDRQh/Q2/CWznEj7pg4iWzhZpy8gX/CYCAlCwp9 eIJVfc2LNzPSTJfh4IqORQiPLiSqRUu6V6YnSbgxY3LaIzNAf9M+SpITUuiBR3b0QRV6 XyBVUbnq3KQRknyXYGwF0t02q1N8SGep/yIIq0hXdmYpqhhEultulfXWfnyX4A0wiahO kham2j8KsJwb5rRSw2bH3BQ5bKslNZ2NkS4EDiGhWDkrMaC2T07J+ICnhhK97ZW8iBe4 8RLVwPA/l55LdoLE4GG7kkMTiOrveJrvh+4sRJN70L3bh5yyeSFJqQlagQs7nu6XRtoR UcDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=UiUTdmhjJlgkUyIvVoReMpiQZ40G8tIY8GthMHJOxCY=; b=DtXFKxgNqrLSZHnLr1GwJYy52XNATu7cKQd2x0TBd5rXp9PXqJcLf1+FofZPkFMg9L HxCJQQJOaRJH6ZQT2fU1sNQW+GvtHG5CBWz8NqVVoGFLQkcfQR10hIGOnBZk100DTDOG ypYDnQyTJA2i9LPi0mg55T6GmAE/VVFf4dq3W6a5kIL0EGBJR18HSnJOxihykGNqkmXP w0Wf0blbsqXMkFtnjFcBmnoCH8o/XJmCxsbTaiM7JiA4DrvLjXgqCJrnkl5t6ZkxXKqB cxrDh/2TzroKDrF0JJYgFvOfDM8Ad79rXLkgcT3dtZ0wiOJ8hpcv8/fv0+TJXlHCJ6zW 0jGQ== X-Gm-Message-State: AJaThX5h+fIzSlVTEinrFiL+h0+loL+lXcJlDhkknexuCCK/Brky92CP /oL9yFxsRvkxZYBlXLye8w1FJ3Idqxpxod/KnU90Pw== X-Google-Smtp-Source: ABhQp+Qnvq5VGOuXHJ6MPf7aYuiK9yy22ktYHgNMlZYNtLtJQKfx1zlFprdmLVaiYYDwiZpRXSFF5f2NjGABvQtCV2o= X-Received: by 10.25.28.10 with SMTP id c10mr684400lfc.29.1509977552047; Mon, 06 Nov 2017 06:12:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.92.139 with HTTP; Mon, 6 Nov 2017 06:12:31 -0800 (PST) From: Henrik Juul Pedersen Date: Mon, 6 Nov 2017 15:12:31 +0100 Message-ID: Subject: Possible bug in Armada-37xx pincontroller To: Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Emil Vesterdahl Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, After some review of a current Armada 37xx design, we stumbled upon some pin numbering, which seems doubly-defined, and doesn't seem to follow the documentation available to us. We haven't gotten our hardware yet, so we haven't been able to test it, but the following patch is as we believe it should be defined. Best regards, Henrik Juul Pedersen LIAB ApS --- PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"), -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 71b944748304..e223fac20993 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -157,8 +157,8 @@ static struct armada_37xx_pin_group armada_37xx_nb_groups[] = { PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"), PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"), PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"), - PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"), - PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"), + PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"), + PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"), PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"), PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),