From patchwork Fri Mar 6 07:31:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "qipeng.zha" X-Patchwork-Id: 447036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 064F5140082 for ; Fri, 6 Mar 2015 18:32:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbbCFHcV (ORCPT ); Fri, 6 Mar 2015 02:32:21 -0500 Received: from mga14.intel.com ([192.55.52.115]:11006 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbbCFHcU convert rfc822-to-8bit (ORCPT ); Fri, 6 Mar 2015 02:32:20 -0500 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 05 Mar 2015 23:27:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,351,1422950400"; d="scan'208";a="463332414" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by FMSMGA003.fm.intel.com with ESMTP; 05 Mar 2015 23:25:53 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 6 Mar 2015 15:31:50 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.46]) with mapi id 14.03.0195.001; Fri, 6 Mar 2015 15:31:48 +0800 From: "Zha, Qipeng" To: "linux-gpio@vger.kernel.org" CC: "linus.walleij@linaro.org" , "Westerberg, Mika" , "Chen, Jason CJ" Subject: RE: [PATCH] pinctrl: update direction_output function of cherryview driver Thread-Topic: [PATCH] pinctrl: update direction_output function of cherryview driver Thread-Index: AQHQVVdpKUJ4C72pVUeQ/pxQlSQqOZ0PFD2Q Date: Fri, 6 Mar 2015 07:31:48 +0000 Message-ID: References: <1425377602-6649-1-git-send-email-qipeng.zha@intel.com> In-Reply-To: <1425377602-6649-1-git-send-email-qipeng.zha@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Linus Are you checking to merge this patch, thanks:) Best wishes Qipeng -----Original Message----- From: Zha, Qipeng Sent: Tuesday, March 03, 2015 6:13 PM To: linux-gpio@vger.kernel.org Cc: linus.walleij@linaro.org; Westerberg, Mika; Zha, Qipeng; Chen, Jason CJ Subject: [PATCH] pinctrl: update direction_output function of cherryview driver From: "qipeng.zha" From the comments of gpiod_direction_output(), need to set @value as initial output, so update the lowlevel routine to make it work. Signed-off-by: jason.cj.chen Signed-off-by: qipeng.zha --- drivers/pinctrl/intel/pinctrl-cherryview.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index e9f8b39..ee6a6de 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1206,6 +1206,7 @@ static int chv_gpio_direction_input(struct gpio_chip *chip, unsigned offset) static int chv_gpio_direction_output(struct gpio_chip *chip, unsigned offset, int value) { + chv_gpio_set(chip, offset, value); return pinctrl_gpio_direction_output(chip->base + offset); } -- 1.8.3.2