| Message ID | 9a55e8b3-bf34-d8a4-f5a6-01e86374f42f@maciej.szmigiero.name |
|---|---|
| State | New |
| Headers | show |
| Series | Revert "gpio: winbond: fix ISA_BUS_API dependency" | expand |
On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero <mail@maciej.szmigiero.name> wrote: > This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72. > > Now that the patch series changing ISA_BUS_API dependency to selection > was merged this reversion will do the same for gpio-winbond driver to > make it consistent with other ISA bus gpio drivers. > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> I still see a number of other users of 'depends on ISA_BUS_API' in linux-next: drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API drivers/gpio/Kconfig: depends on ISA_BUS_API drivers/gpio/Kconfig: depends on ISA_BUS_API drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API Did you change all of the above? I would really like to avoid mixing 'select' and 'depends on' here, as that will likely cause other circular dependencies in the future. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2018-02-23 at 16:19 +0100, Arnd Bergmann wrote: > On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero > <mail@maciej.szmigiero.name> wrote: > I would really like to avoid mixing > 'select' and 'depends on' here, as that will likely cause other > circular > dependencies in the future. Agree. And it doesn't make sense to do in a separate changes.
On Fri, Feb 23, 2018 at 04:19:01PM +0100, Arnd Bergmann wrote: >On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero ><mail@maciej.szmigiero.name> wrote: >> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72. >> >> Now that the patch series changing ISA_BUS_API dependency to selection >> was merged this reversion will do the same for gpio-winbond driver to >> make it consistent with other ISA bus gpio drivers. >> >> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> > >I still see a number of other users of 'depends on ISA_BUS_API' in linux-next: > >drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API >drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API >drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API >drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API >drivers/gpio/Kconfig: depends on ISA_BUS_API >drivers/gpio/Kconfig: depends on ISA_BUS_API >drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API >drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API >drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API >drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API > >Did you change all of the above? I would really like to avoid mixing >'select' and 'depends on' here, as that will likely cause other circular >dependencies in the future. > > Arnd Those 'depends on' for ISA_BUS_API are resolved in the devel branch of the linux-gpio tree; this revert patch should be applied there before being picked up later for linux-next. William Breathitt Gray -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero <mail@maciej.szmigiero.name> wrote: > This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72. > > Now that the patch series changing ISA_BUS_API dependency to selection > was merged this reversion will do the same for gpio-winbond driver to > make it consistent with other ISA bus gpio drivers. > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index dff99871bca8..6d481ef03623 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -722,7 +722,7 @@ config GPIO_TS5500 config GPIO_WINBOND tristate "Winbond Super I/O GPIO support" - depends on ISA_BUS_API + select ISA_BUS_API help This option enables support for GPIOs found on Winbond Super I/O chips.
This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72. Now that the patch series changing ISA_BUS_API dependency to selection was merged this reversion will do the same for gpio-winbond driver to make it consistent with other ISA bus gpio drivers. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html