| Message ID | 9996cb86818d2e935494d6b414d549432f91797a.1657528504.git.geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91 | expand |
On 11/07/2022 at 10:36, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence > add a dependency on ARCH_AT91, to prevent asking the user about this > driver when configuring a kernel without AT91/Microchip SoC support. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Looks good to me: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> I'm adding to the thread my colleagues from lan966 and mpfs if it happens that they use this same IP on their SoC. Anyway, we can add them afterwards. Thanks for your heads-up Geert, Best regards, Nicolas > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 63a89ff7865e374f..1852656d5eb248f6 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU > tristate "SAMA5D2 PIOBU GPIO support" > depends on MFD_SYSCON > depends on OF_GPIO > + depends on ARCH_AT91 || COMPILE_TEST > select GPIO_SYSCON > help > Say yes here to use the PIOBU pins as GPIOs. > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 11/07/2022 13:03, Nicolas Ferre wrote: > On 11/07/2022 at 10:36, Geert Uytterhoeven wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence >> add a dependency on ARCH_AT91, to prevent asking the user about this >> driver when configuring a kernel without AT91/Microchip SoC support. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Looks good to me: > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > > I'm adding to the thread my colleagues from lan966 and mpfs if it > happens that they use this same IP on their SoC. Anyway, we can > add them afterwards. Not on FPGAs, so you're safe there!
On Mon, Jul 11, 2022 at 12:27 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence > add a dependency on ARCH_AT91, to prevent asking the user about this > driver when configuring a kernel without AT91/Microchip SoC support. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 63a89ff7865e374f..1852656d5eb248f6 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU > tristate "SAMA5D2 PIOBU GPIO support" > depends on MFD_SYSCON > depends on OF_GPIO > + depends on ARCH_AT91 || COMPILE_TEST > select GPIO_SYSCON > help > Say yes here to use the PIOBU pins as GPIOs. > -- > 2.25.1 > Applied, thanks! Bart
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 63a89ff7865e374f..1852656d5eb248f6 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU tristate "SAMA5D2 PIOBU GPIO support" depends on MFD_SYSCON depends on OF_GPIO + depends on ARCH_AT91 || COMPILE_TEST select GPIO_SYSCON help Say yes here to use the PIOBU pins as GPIOs.
The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence add a dependency on ARCH_AT91, to prevent asking the user about this driver when configuring a kernel without AT91/Microchip SoC support. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)