From patchwork Sat Jan 6 19:52:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856457 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zDXJ11Rhkz9s0g for ; Sun, 7 Jan 2018 06:52:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbeAFTwb (ORCPT ); Sat, 6 Jan 2018 14:52:31 -0500 Received: from mout.web.de ([212.227.15.14]:58657 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbeAFTwa (ORCPT ); Sat, 6 Jan 2018 14:52:30 -0500 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lx7OL-1ew0xe3GzB-016gGu; Sat, 06 Jan 2018 20:52:27 +0100 Subject: [PATCH v2] pinctrl: mcp23s08: Combine two function calls into one in mcp23s08_dbg_show() To: linux-gpio@vger.kernel.org, Linus Walleij , Sebastian Reichel Cc: LKML , kernel-janitors@vger.kernel.org References: <0510a811-e653-6310-5c7f-8d6434efca2a@users.sourceforge.net> From: SF Markus Elfring Message-ID: <3f5bd410-e685-d067-14e3-b8e77552a121@users.sourceforge.net> Date: Sat, 6 Jan 2018 20:52:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:/ApjJPfCnqmiYgnPAmUAJX0oLhqjDtMTYOhKLNM+RKxUQrY3SnR vKvPuiLjh2vH+Z15raKtS5Uj3JSaosRTufYwnjvRry9Axs5rp9N0oQJmYuri2ImECjIwqFZ U2R1K1QaS+D0KKKNt1TuEdPh8/o0kNEeZTT4Dh+VE2iFh2JuDe0n1vSY83ThynlOYKgOmOD KHMx9bedvft+RvZPyr2Nw== X-UI-Out-Filterresults: notjunk:1; V01:K0:e5K3LP/dgGs=:iZaTwrwlCRpkHfrL75psG9 bZtbHBnAtdRK25fxmP3j7HXKQUMUHoO+QZCoT86kn0JH+xiyJNW/M5wsEJfijp0kdGXM7qhhp r1t22IQ5K9pI6cIovRLOlzR20fbt7q1jccVa3eFV11ZWPM8dWJtPzCPu+lEE8LbzK2QSgpScx JP6f+5Ce8INJDxX6z3leFl2z/V0kjDw5AhAvsVluZSq2PZWUtxExyY5HHBuLMv6Ax7SKcOn8u VAkAOu56yDAVR/SNzCj6LH2Qgsl5dzMEp1pYlBCJMdT0WM8pGe2AHvX4TvZIYECnUiETGmaTo +OXslkGrX3odfFe3gn94zPRHT11bFDguCHFhJ3jPYWcM1TU5YIrJFEQRMlyhqPF9b8pRqP6Jy rIe7AL3IbTq1HYwTqApbLDXd0a51ZyPqG5QG0HSZyai6rdMZd1QtKLx4Mxt5h5JfCOLhSIVOQ HkIguWIh7245TE1sSLXnkX0S/ZNwSuZemlDegIL/3nnP2i2Zt2OqU9l4QU/VuBaBc+HalKKp3 xDGd7om1pgNsjlfatfOH2msx2YE30jQ6YWCu51rp6IqUreKs7hr7IkOEVKw5tPuWzu3JYW3ju WIrv94J/BchRl64RvkB34sn3bHAe2pKjhBlNLP8eT9WkZzHr0QKrmdTSxV1rqGM1kqMMFd9Dr Q3d7nOhPZ9UhqKR3UdC/qTH746ZOURz73P8+xeKBzgFvE8E+x/Pjj96mS1/ZuFbelPlOV8n/f s5n/mTOrx4Ycl73PI2t0HDQDv2h8dF5B6yDKiRAEj3mTkhtAer0V8z0olL+U3j3c51pySZwp8 if2l8s7GrrsSf1/Q0jZS9LWTc9o7CLtgnr2c1V6edg9xEZdtJg= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Sat, 6 Jan 2018 20:40:04 +0100 * Print a line break together with other data in a single function call. * Adjust indentation. Signed-off-by: Markus Elfring --- v2: This update suggestion was rebased on source files from the software "Linux next-20180105". drivers/pinctrl/pinctrl-mcp23s08.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index e6ad36dea3e5..95d548f3ba53 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -748,13 +748,12 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip) if (!label) continue; - seq_printf(s, " gpio-%-3d P%c.%d (%-12s) %s %s %s", - chip->base + t, bank, t, label, - (iodir & mask) ? "in " : "out", - (gpio & mask) ? "hi" : "lo", - (gppu & mask) ? "up" : " "); + seq_printf(s, " gpio-%-3d P%c.%d (%-12s) %s %s %s\n", + chip->base + t, bank, t, label, + (iodir & mask) ? "in " : "out", + (gpio & mask) ? "hi" : "lo", + (gppu & mask) ? "up" : " "); /* NOTE: ignoring the irq-related registers */ - seq_puts(s, "\n"); } done: mutex_unlock(&mcp->lock);