| Message ID | 24505deb08d050eb4ce38f186f4037d7541ea217.1605722628.git.cristian.ciocaltea@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] pinctrl: actions: pinctrl-s500: Constify s500_padinfo[] | expand |
On Wed, Nov 18, 2020 at 7:10 PM Cristian Ciocaltea <cristian.ciocaltea@gmail.com> wrote: > s500_padinfo[] is never modified and should be made 'const' to allow > the compiler to optimize code generation, i.e. put it in the text > section instead of the data section. > > Before: > text data bss dec hex filename > 12503 5088 0 17591 44b7 drivers/pinctrl/actions/pinctrl-s500.o > > After: > text data bss dec hex filename > 14435 3156 0 17591 44b7 drivers/pinctrl/actions/pinctrl-s500.o > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/actions/pinctrl-s500.c b/drivers/pinctrl/actions/pinctrl-s500.c index 38e30914af6e..ced778079b76 100644 --- a/drivers/pinctrl/actions/pinctrl-s500.c +++ b/drivers/pinctrl/actions/pinctrl-s500.c @@ -1485,7 +1485,7 @@ static PAD_PULLCTL_CONF(DNAND_D6, 2, 2, 1); static PAD_PULLCTL_CONF(DNAND_D7, 2, 2, 1); /* Pad info table */ -static struct owl_padinfo s500_padinfo[NUM_PADS] = { +static const struct owl_padinfo s500_padinfo[NUM_PADS] = { [DNAND_DQS] = PAD_INFO_PULLCTL(DNAND_DQS), [DNAND_DQSN] = PAD_INFO_PULLCTL(DNAND_DQSN), [ETH_TXD0] = PAD_INFO_ST(ETH_TXD0),
s500_padinfo[] is never modified and should be made 'const' to allow the compiler to optimize code generation, i.e. put it in the text section instead of the data section. Before: text data bss dec hex filename 12503 5088 0 17591 44b7 drivers/pinctrl/actions/pinctrl-s500.o After: text data bss dec hex filename 14435 3156 0 17591 44b7 drivers/pinctrl/actions/pinctrl-s500.o Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> --- drivers/pinctrl/actions/pinctrl-s500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)