| Message ID | 20251003-fix-mt8196-pinctrl-regnames-v1-1-4d22031140f0@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: mediatek: mt8196: align register base names to dt-bindings ones | expand |
Il 03/10/25 16:00, Louis-Alexis Eyraud ha scritto: > The mt8196-pinctrl driver requires to probe that a device tree uses > in the device node the same names than mt8196_pinctrl_register_base_names > array. But they are not matching the required ones in the > "mediatek,mt8196-pinctrl" dt-bindings, leading to possible dtbs check > issues. > So, align all mt8196_pinctrl_register_base_names entries on dt-bindings > ones. > > Fixes: f7a29377c253 ("pinctrl: mediatek: Add pinctrl driver on mt8196") > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, Oct 3, 2025 at 4:01 PM Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> wrote: > The mt8196-pinctrl driver requires to probe that a device tree uses > in the device node the same names than mt8196_pinctrl_register_base_names > array. But they are not matching the required ones in the > "mediatek,mt8196-pinctrl" dt-bindings, leading to possible dtbs check > issues. > So, align all mt8196_pinctrl_register_base_names entries on dt-bindings > ones. > > Fixes: f7a29377c253 ("pinctrl: mediatek: Add pinctrl driver on mt8196") > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8196.c b/drivers/pinctrl/mediatek/pinctrl-mt8196.c index 82a73929c7a0fc0fb841b5fe313d905c8478044a..dec957c1724b014522a70ed38057e162fe9e25af 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mt8196.c +++ b/drivers/pinctrl/mediatek/pinctrl-mt8196.c @@ -1801,10 +1801,8 @@ static const struct mtk_pin_reg_calc mt8196_reg_cals[PINCTRL_PIN_REG_MAX] = { }; static const char * const mt8196_pinctrl_register_base_names[] = { - "iocfg0", "iocfg_rt", "iocfg_rm1", "iocfg_rm2", - "iocfg_rb", "iocfg_bm1", "iocfg_bm2", "iocfg_bm3", - "iocfg_lt", "iocfg_lm1", "iocfg_lm2", "iocfg_lb1", - "iocfg_lb2", "iocfg_tm1", "iocfg_tm2", "iocfg_tm3", + "base", "rt", "rm1", "rm2", "rb", "bm1", "bm2", "bm3", + "lt", "lm1", "lm2", "lb1", "lb2", "tm1", "tm2", "tm3", }; static const struct mtk_eint_hw mt8196_eint_hw = {
The mt8196-pinctrl driver requires to probe that a device tree uses in the device node the same names than mt8196_pinctrl_register_base_names array. But they are not matching the required ones in the "mediatek,mt8196-pinctrl" dt-bindings, leading to possible dtbs check issues. So, align all mt8196_pinctrl_register_base_names entries on dt-bindings ones. Fixes: f7a29377c253 ("pinctrl: mediatek: Add pinctrl driver on mt8196") Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> --- drivers/pinctrl/mediatek/pinctrl-mt8196.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- base-commit: 4a7bcf9e0158d9976525370ff84401a1e955bbee change-id: 20251003-fix-mt8196-pinctrl-regnames-60d30873ca23 Best regards,