| Message ID | 20240417141914.2905621-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] gpiolib: swnode: Remove wrong header inclusion | expand |
On Wed, Apr 17, 2024 at 4:19 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The flags in the software node properties are supposed to be > the GPIO lookup flags, which are provided by gpio/machine.h, > as the software nodes are the kernel internal thing and doesn't > need to rely to any of ABIs. > > Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/gpio/property.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/gpio/property.h b/include/linux/gpio/property.h > index 6c75c8bd44a0..1a14e239221f 100644 > --- a/include/linux/gpio/property.h > +++ b/include/linux/gpio/property.h > @@ -2,7 +2,6 @@ > #ifndef __LINUX_GPIO_PROPERTY_H > #define __LINUX_GPIO_PROPERTY_H > > -#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */ > #include <linux/property.h> > > #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \ > -- > 2.43.0.rc1.1336.g36b5255a03ac > Applied, thanks! Bart
diff --git a/include/linux/gpio/property.h b/include/linux/gpio/property.h index 6c75c8bd44a0..1a14e239221f 100644 --- a/include/linux/gpio/property.h +++ b/include/linux/gpio/property.h @@ -2,7 +2,6 @@ #ifndef __LINUX_GPIO_PROPERTY_H #define __LINUX_GPIO_PROPERTY_H -#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */ #include <linux/property.h> #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
The flags in the software node properties are supposed to be the GPIO lookup flags, which are provided by gpio/machine.h, as the software nodes are the kernel internal thing and doesn't need to rely to any of ABIs. Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/gpio/property.h | 1 - 1 file changed, 1 deletion(-)